[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: More kio_sftp login related fixes
From: "Commit Hook" <null () kde ! org>
Date: 2012-07-06 21:42:30
Message-ID: 20120706214230.12140.44249 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104642/#review15480
-----------------------------------------------------------
This review has been submitted with commit 51d580a019c67a7bf6751db8391738aa27c8ef66 \
by Dawit Alemayehu to branch master.
- Commit Hook
On April 26, 2012, 3:42 a.m., Dawit Alemayehu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104642/
> -----------------------------------------------------------
>
> (Updated April 26, 2012, 3:42 a.m.)
>
>
> Review request for KDE Runtime and Andreas Schneider.
>
>
> Description
> -------
>
> This is the last one of the sftp login fixes series and addresses the following \
> problems:
> #1. Correctly handle login failure that results from a different username being \
> used when setting the SSH_OPTIONS_USER option and calling ssh_userauth_password. I \
> think this might have been due to a regression caused by my previous patch. \
> Nonetheless, this patch addresses it.
> #2. Changed public key authentication so that incorrect public key passwords \
> generate a retry dialog instead of simply continuing to the next available \
> authentication method.
>
> Diffs
> -----
>
> kioslave/sftp/kio_sftp.h f497c0b
> kioslave/sftp/kio_sftp.cpp e38c629
>
> Diff: http://git.reviewboard.kde.org/r/104642/diff/
>
>
> Testing
> -------
>
> Testing for #1:
> ===========
> 1.) Make sure a ssh server is running on your system.
> 2.) Attempt to login into your system: sftp://127.0.0.1.
> 3.) When prompted for credentials, enter a user name other than the currently \
> logged in user.
> Current Behavior:
> Login attempt will simply fail eventually and and error page is displayed.
>
> New (Fixed) Behavior:
> Successfully log into the server with the specified user name.
>
>
> Testing for #2:
> ===========
> 1.) Create a ssh key with password protection and add it to the authorized_keys \
> file. 2.) Make sure the ssh public key is in your .ssh directory.
> 3.) Attempt to login into your system: sftp://127.0.0.1
> 4.) When prompted for the passpharse for the key, enter a bogus password.
>
> Current behavior:
> No retry dialog is ever shown for an invalid or improper ssh key passphrase and the \
> process simply moves on to the next authentication method.
> New(Fixed) behavior:
> Show a retry dialog if the failure is due to invalid password. If the user then \
> presses cancel on the retry dialog, simply behave the same way as if the cancel \
> button is pressed on the password dialog. That is continue onto the next \
> authentication method.
>
> Thanks,
>
> Dawit Alemayehu
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104642/">http://git.reviewboard.kde.org/r/104642/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been \
submitted with commit 51d580a019c67a7bf6751db8391738aa27c8ef66 by Dawit Alemayehu to \
branch master.</pre> <br />
<p>- Commit</p>
<br />
<p>On April 26th, 2012, 3:42 a.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Runtime and Andreas Schneider.</div>
<div>By Dawit Alemayehu.</div>
<p style="color: grey;"><i>Updated April 26, 2012, 3:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the last one of the sftp login fixes series and addresses the \
following problems:
#1. Correctly handle login failure that results from a different username being used \
when setting the SSH_OPTIONS_USER option and calling ssh_userauth_password. I think \
this might have been due to a regression caused by my previous patch. Nonetheless, \
this patch addresses it.
#2. Changed public key authentication so that incorrect public key passwords generate \
a retry dialog instead of simply continuing to the next available authentication \
method. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testing for #1: ===========
1.) Make sure a ssh server is running on your system.
2.) Attempt to login into your system: sftp://127.0.0.1.
3.) When prompted for credentials, enter a user name other than the currently logged \
in user.
Current Behavior:
Login attempt will simply fail eventually and and error page is displayed.
New (Fixed) Behavior:
Successfully log into the server with the specified user name.
Testing for #2:
===========
1.) Create a ssh key with password protection and add it to the authorized_keys file.
2.) Make sure the ssh public key is in your .ssh directory.
3.) Attempt to login into your system: sftp://127.0.0.1
4.) When prompted for the passpharse for the key, enter a bogus password.
Current behavior:
No retry dialog is ever shown for an invalid or improper ssh key passphrase and the \
process simply moves on to the next authentication method.
New(Fixed) behavior:
Show a retry dialog if the failure is due to invalid password. If the user then \
presses cancel on the retry dialog, simply behave the same way as if the cancel \
button is pressed on the password dialog. That is continue onto the next \
authentication method.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kioslave/sftp/kio_sftp.h <span style="color: grey">(f497c0b)</span></li>
<li>kioslave/sftp/kio_sftp.cpp <span style="color: grey">(e38c629)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104642/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic