[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    khtml/kmultipart/kmultipart.cpp uses wrong signal
From:       Martin Koller <kollix () aon ! at>
Date:       2012-07-06 21:36:13
Message-ID: 201207062336.18308.kollix () aon ! at
[Download RAW message or body]


Hi,

for this trivial bugfix I'd rather not go through reviewboard:

Error:

Object::connect: No such signal KHTMLPartBrowserExtension::openURLNotify()
Object::connect:  (sender name:   'KHTMLBrowserExtension')
Object::connect: No such signal KHTMLPartBrowserExtension::setLocationBarURL(QString)
Object::connect:  (sender name:   'KHTMLBrowserExtension')

Patch:

--- a/khtml/kmultipart/kmultipart.cpp
+++ b/khtml/kmultipart/kmultipart.cpp
@@ -356,8 +356,8 @@ void KMultiPart::setPart( const QString& mimeType )
         // Forward signals from the part's browser extension
         // this is very related (but not exactly like) \
KHTMLPart::processObjectRequest  
-        connect( childExtension, SIGNAL(openURLNotify()),
-                 m_extension, SIGNAL(openURLNotify()) );
+        connect( childExtension, SIGNAL(openUrlNotify()),
+                 m_extension, SIGNAL(openUrlNotify()) );
 
         connect( childExtension, \
SIGNAL(openUrlRequestDelayed(KUrl,KParts::OpenUrlArguments,KParts::BrowserArguments)),
                
                  m_extension, \
SIGNAL(openUrlRequest(KUrl,KParts::OpenUrlArguments,KParts::BrowserArguments)) ); @@ \
-380,8 +380,8 @@ void KMultiPart::setPart( const QString& mimeType )  
         connect( childExtension, SIGNAL(enableAction(const char*,bool)),
                  m_extension, SIGNAL(enableAction(const char*,bool)) );
-        connect( childExtension, SIGNAL(setLocationBarURL(QString)),
-                 m_extension, SIGNAL(setLocationBarURL(QString)) );
+        connect( childExtension, SIGNAL(setLocationBarUrl(QString)),
+                 m_extension, SIGNAL(setLocationBarUrl(QString)) );
         connect( childExtension, SIGNAL(setIconUrl(KUrl)),
                  m_extension, SIGNAL(setIconUrl(KUrl)) );
         connect( childExtension, SIGNAL(loadingProgress(int)),

-- 
Best regards/Schöne Grüße

Martin
A: Because it breaks the logical sequence of discussion
Q: Why is top posting bad?

()  ascii ribbon campaign - against html e-mail 
/\  www.asciiribbon.org   - against proprietary attachments

Geschenkideen, Accessoires, Seifen, Kulinarisches: www.bibibest.at


["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]