--===============3915611713737598806== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104642/#review15480 ----------------------------------------------------------- This review has been submitted with commit 51d580a019c67a7bf6751db8391738aa= 27c8ef66 by Dawit Alemayehu to branch master. - Commit Hook On April 26, 2012, 3:42 a.m., Dawit Alemayehu wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/104642/ > ----------------------------------------------------------- > = > (Updated April 26, 2012, 3:42 a.m.) > = > = > Review request for KDE Runtime and Andreas Schneider. > = > = > Description > ------- > = > This is the last one of the sftp login fixes series and addresses the fol= lowing problems: = > = > #1. Correctly handle login failure that results from a different username= being used when setting the = > SSH_OPTIONS_USER option and calling ssh_userauth_password. I think this m= ight have been due to > a regression caused by my previous patch. Nonetheless, this patch address= es it. > = > #2. Changed public key authentication so that incorrect public key passwo= rds generate a retry dialog > instead of simply continuing to the next available authentication method. > = > = > Diffs > ----- > = > kioslave/sftp/kio_sftp.h f497c0b = > kioslave/sftp/kio_sftp.cpp e38c629 = > = > Diff: http://git.reviewboard.kde.org/r/104642/diff/ > = > = > Testing > ------- > = > Testing for #1: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1.) Make sure a ssh server is running on your system. > 2.) Attempt to login into your system: sftp://127.0.0.1. > 3.) When prompted for credentials, enter a user name other than the curre= ntly logged in user. > = > Current Behavior: > Login attempt will simply fail eventually and and error page is displayed. > = > New (Fixed) Behavior: > Successfully log into the server with the specified user name. > = > = > Testing for #2: > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > 1.) Create a ssh key with password protection and add it to the authorize= d_keys file. > 2.) Make sure the ssh public key is in your .ssh directory. > 3.) Attempt to login into your system: sftp://127.0.0.1 > 4.) When prompted for the passpharse for the key, enter a bogus password. = > = > Current behavior: > No retry dialog is ever shown for an invalid or improper ssh key passphra= se and the process simply moves on to the next authentication method. > = > New(Fixed) behavior: > Show a retry dialog if the failure is due to invalid password. If the use= r then presses cancel on the retry dialog, simply behave the same way as if= the cancel button is pressed on the password dialog. That is continue onto= the next authentication method. > = > = > Thanks, > = > Dawit Alemayehu > = > --===============3915611713737598806== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/104642/ 

This revie=
w has been submitted with commit 51d580a019c67a7bf6751db8391738aa27c8ef66 b=
y Dawit Alemayehu to branch master.

- Commit


On April 26th, 2012, 3:42 a.m., Dawit Alemayehu wrote:

Review request for KDE Runtime and Andreas Schneider.
By Dawit Alemayehu.

Updated April 26, 2012, 3:42 a.m.

Descripti= on 

This is the last one of the sftp login fixes series and addr=
esses the following problems:    =


#1. Correctly handle login failure that results from a different username b=
eing used when setting the =

SSH_OPTIONS_USER option and calling ssh_userauth_password. I think this mig=
ht have been due to
a regression caused by my previous patch. Nonetheless, this patch addresses=
 it.

#2. Changed public key authentication so that incorrect public key password=
s generate a retry dialog
instead of simply continuing to the next available authentication method.

Testing <= /h1> 
Testing for #1:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
1.) Make sure a ssh server is running on your system.
2.) Attempt to login into your system: sftp://127.0.0.1.
3.) When prompted for credentials, enter a user name other than the current=
ly logged in user.

Current Behavior:
Login attempt will simply fail eventually and and error page is displayed.

New (Fixed) Behavior:
Successfully log into the server with the specified user name.


Testing for #2:
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
1.) Create a ssh key with password protection and add it to the authorized_=
keys file.
2.) Make sure the ssh public key is in your .ssh directory.
3.) Attempt to login into your system: sftp://127.0.0.1
4.) When prompted for the passpharse for the key, enter a bogus password. =


Current behavior:
No retry dialog is ever shown for an invalid or improper ssh key passphrase=
 and the process simply moves on to the next authentication method.

New(Fixed) behavior:
Show a retry dialog if the failure is due to invalid password. If the user =
then presses cancel on the retry dialog, simply behave the same way as if t=
he cancel button is pressed on the password dialog. That is continue onto t=
he next authentication method.

Diffs=

  • kioslave/sftp/kio_sftp.h (f497c0b)<= /li>
  • kioslave/sftp/kio_sftp.cpp (e38c629)

View Diff
--===============3915611713737598806==--