[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    Re: [PATCH] KPDF crashes on .PS documents
From:       Albert Astals Cid <astals11 () terra ! es>
Date:       2005-02-24 9:37:17
Message-ID: 200502241037.18363.astals11 () terra ! es
[Download RAW message or body]

But we can plug the catalog no?

Anyway IMHO we can just apply that patch at the moment. It will make 
openDocument return false for all files that are not of mimetype pdf and that 
will make the part say "Could not open %1"

Albert

A Dijous 24 Febrer 2005 10:21, Lukáš Tinkl va escriure:
> Dne čt 24. února 2005 9:46 Albert Astals Cid napsal(a):
> > Are there really such stupid people?
> >
> > I guess i18n people is going to kill you if you introduce another last
> > minute string (they already did with my typo fix from Continous ->
> > Continuous).
> >
> > Could we use "Wrong format\n%1" present at kviewpresenterplugin.po?
>
> No you can't, it's another application; try to reuse something from
> kpdf.po.

["kpdf.ps.patch" (text/x-diff)]

Index: core/document.cpp
===================================================================
RCS file: /home/kde/kdegraphics/kpdf/core/document.cpp,v
retrieving revision 1.34
diff -u -b -r1.34 document.cpp
--- core/document.cpp	19 Feb 2005 13:04:41 -0000	1.34
+++ core/document.cpp	24 Feb 2005 09:36:31 -0000
@@ -140,8 +140,8 @@
     QString mimeName = mime->name();
     if ( mimeName == "application/pdf" )
         generator = new PDFGenerator( this );
-    else if ( mimeName == "application/postscript" )
-        kdError() << "PS generator not available" << endl;
+//    else if ( mimeName == "application/postscript" )
+//        kdError() << "PS generator not available" << endl;
     else
     {
         kdWarning() << "Unknown mimetype '" << mimeName << "'." << endl;


[prev in list] [next in list] [prev in thread] [next in thread]