From kde-core-devel  Thu Feb 24 09:37:17 2005
From: Albert Astals Cid <astals11 () terra ! es>
Date: Thu, 24 Feb 2005 09:37:17 +0000
To: kde-core-devel
Subject: Re: [PATCH] KPDF crashes on .PS documents
Message-Id: <200502241037.18363.astals11 () terra ! es>
X-MARC-Message: https://marc.info/?l=kde-core-devel&m=110923790105796
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--Boundary-00=_OBaHCtInTIJi2PL"

--Boundary-00=_OBaHCtInTIJi2PL
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

But we can plug the catalog no?

Anyway IMHO we can just apply that patch at the moment. It will make=20
openDocument return false for all files that are not of mimetype pdf and th=
at=20
will make the part say "Could not open %1"

Albert

A Dijous 24 Febrer 2005 10:21, Luk=C3=A1=C5=A1 Tinkl va escriure:
> Dne =C4=8Dt 24. =C3=BAnora 2005 9:46 Albert Astals Cid napsal(a):
> > Are there really such stupid people?
> >
> > I guess i18n people is going to kill you if you introduce another last
> > minute string (they already did with my typo fix from Continous ->
> > Continuous).
> >
> > Could we use "Wrong format\n%1" present at kviewpresenterplugin.po?
>
> No you can't, it's another application; try to reuse something from
> kpdf.po.

--Boundary-00=_OBaHCtInTIJi2PL
Content-Type: text/x-diff;
  charset="utf-8";
  name="kpdf.ps.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename="kpdf.ps.patch"

Index: core/document.cpp
===================================================================
RCS file: /home/kde/kdegraphics/kpdf/core/document.cpp,v
retrieving revision 1.34
diff -u -b -r1.34 document.cpp
--- core/document.cpp	19 Feb 2005 13:04:41 -0000	1.34
+++ core/document.cpp	24 Feb 2005 09:36:31 -0000
@@ -140,8 +140,8 @@
     QString mimeName = mime->name();
     if ( mimeName == "application/pdf" )
         generator = new PDFGenerator( this );
-    else if ( mimeName == "application/postscript" )
-        kdError() << "PS generator not available" << endl;
+//    else if ( mimeName == "application/postscript" )
+//        kdError() << "PS generator not available" << endl;
     else
     {
         kdWarning() << "Unknown mimetype '" << mimeName << "'." << endl;

--Boundary-00=_OBaHCtInTIJi2PL--