[prev in list] [next in list] [prev in thread] [next in thread]
List: kwrite-devel
Subject: Re: Review Request 121249: add translationDomain to rc file headers
From: "Kevin Funk" <kfunk () kde ! org>
Date: 2014-11-29 10:03:51
Message-ID: 20141129100351.11306.36215 () probe ! kde ! org
[Download RAW message or body]
--===============3636211074147904809==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121249/#review71076
-----------------------------------------------------------
Ship it!
addons/snippets/ui.rc
<https://git.reviewboard.kde.org/r/121249/#comment49651>
In the other .rc files you don't suffix them with 'plugin'. Can we try to be \
consistent?
What's the counter-part for that identifier? the basename of the .pot file? Do we \
still need `insertCatalog(...) calls` inside the plugin? (Just trying to understand \
what's needed)
- Kevin Funk
On Nov. 25, 2014, 8:05 p.m., Burkhard Lück wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121249/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 8:05 p.m.)
>
>
> Review request for Kate.
>
>
> Repository: kate
>
>
> Description
> -------
>
> see http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.html#link_noncode
>
>
> Diffs
> -----
>
> addons/mailfiles/ui.rc 566a2be
> addons/openheader/ui.rc 29fced4
> addons/pate/src/plugins/block_ui.rc ab2743c
> addons/pate/src/plugins/cmake_utils/cmake_utils_ui.rc c5cb2ef
> addons/pate/src/plugins/color_tools_ui.rc 4a88f47
> addons/pate/src/plugins/commentar_ui.rc ee87a3e
> addons/pate/src/plugins/expand/expand_ui.rc 76f0c4c
> addons/pate/src/plugins/format_ui.rc ea99d0f
> addons/pate/src/plugins/gid/gid_ui.rc fea118d
> addons/pate/src/plugins/js_utils/js_utils_ui.rc d3c1892
> addons/pate/src/plugins/try_open_file_ui.rc b571afa
> addons/pate/src/plugins/xml_pretty_ui.rc b2aaf2e
> addons/pate/src/ui.rc 42a5c37
> addons/project/ui.rc 3a2210c
> addons/search/ui.rc bf41b30
> addons/snippets/ui.rc a698da5
> addons/symbolviewer/ui.rc 7332240
> addons/tabswitcher/ui.rc ff08bea
> addons/textfilter/ui.rc d8bd7eb
> addons/xmlcheck/ui.rc ae993b7
> addons/xmltools/ui.rc 08e5fb8
> kate/data/kateui.rc dc5ea8a
> addons/katebuild-plugin/ui.rc 0d6e79f
> addons/katesql/ui.rc 9fde7f6
> addons/konsole/ui.rc 3499c0d
> addons/kttsd/ui.rc 1472ce7
> addons/filetree/ui.rc 5f515e7
> addons/gdbplugin/ui.rc dfe6cd0
> addons/kate-ctags/ui.rc c3e957a
> addons/close-except-like/ui.rc 8b11ebd
> addons/filetemplates/plugin/ui.rc 1b7ebea
>
> Diff: https://git.reviewboard.kde.org/r/121249/diff/
>
>
> Testing
> -------
>
> debug() calls show query for translation if strings with correct domain
>
>
> Thanks,
>
> Burkhard Lück
>
>
--===============3636211074147904809==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121249/">https://git.reviewboard.kde.org/r/121249/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/121249/diff/1/?file=330710#file330710line3" \
style="color: black; font-weight: bold; text-decoration: \
underline;">addons/snippets/ui.rc</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">3</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="o"><</span><span class="n">gui</span> <span class="n">name</span><span \
class="o">=</span><span class="s">"katesnippets"</span> <span \
class="n">library</span><span class="o">=</span><span \
class="s">"katesnippetsplugin"</span> <span class="n">version</span><span \
class="o">=</span><span class="s">"<span class="hl">1</span>"</span><span \
class="o">></span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">3</font></th> \
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="o"><</span><span class="n">gui</span> <span \
class="n">name</span><span class="o">=</span><span \
class="s">"katesnippets"</span> <span class="n">library</span><span \
class="o">=</span><span class="s">"katesnippetsplugin"</span> <span \
class="n">version</span><span class="o">=</span><span class="s">"<span \
class="hl">2"</span></span><span class="hl"> </span><span class="n"><span \
class="hl">translationDomain</span></span><span class="o"><span \
class="hl">=</span></span><span class="s"><span \
class="hl">"katesnippetsplugin</span>"</span><span \
class="o">></span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In \
the other .rc files you don't suffix them with 'plugin'. Can we try to be \
consistent?</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What's the counter-part for that identifier? the \
basename of the .pot file? Do we still need <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">insertCatalog(...) calls</code> inside the plugin? (Just trying to \
understand what's needed)</p></pre> </div>
</div>
<br />
<p>- Kevin Funk</p>
<br />
<p>On November 25th, 2014, 8:05 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Kate.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Nov. 25, 2014, 8:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kate
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see \
http://api.kde.org/frameworks-api/frameworks5-apidocs/ki18n/html/prg_guide.html#link_noncode</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">debug() calls show query for translation if strings \
with correct domain</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>addons/mailfiles/ui.rc <span style="color: grey">(566a2be)</span></li>
<li>addons/openheader/ui.rc <span style="color: grey">(29fced4)</span></li>
<li>addons/pate/src/plugins/block_ui.rc <span style="color: \
grey">(ab2743c)</span></li>
<li>addons/pate/src/plugins/cmake_utils/cmake_utils_ui.rc <span style="color: \
grey">(c5cb2ef)</span></li>
<li>addons/pate/src/plugins/color_tools_ui.rc <span style="color: \
grey">(4a88f47)</span></li>
<li>addons/pate/src/plugins/commentar_ui.rc <span style="color: \
grey">(ee87a3e)</span></li>
<li>addons/pate/src/plugins/expand/expand_ui.rc <span style="color: \
grey">(76f0c4c)</span></li>
<li>addons/pate/src/plugins/format_ui.rc <span style="color: \
grey">(ea99d0f)</span></li>
<li>addons/pate/src/plugins/gid/gid_ui.rc <span style="color: \
grey">(fea118d)</span></li>
<li>addons/pate/src/plugins/js_utils/js_utils_ui.rc <span style="color: \
grey">(d3c1892)</span></li>
<li>addons/pate/src/plugins/try_open_file_ui.rc <span style="color: \
grey">(b571afa)</span></li>
<li>addons/pate/src/plugins/xml_pretty_ui.rc <span style="color: \
grey">(b2aaf2e)</span></li>
<li>addons/pate/src/ui.rc <span style="color: grey">(42a5c37)</span></li>
<li>addons/project/ui.rc <span style="color: grey">(3a2210c)</span></li>
<li>addons/search/ui.rc <span style="color: grey">(bf41b30)</span></li>
<li>addons/snippets/ui.rc <span style="color: grey">(a698da5)</span></li>
<li>addons/symbolviewer/ui.rc <span style="color: grey">(7332240)</span></li>
<li>addons/tabswitcher/ui.rc <span style="color: grey">(ff08bea)</span></li>
<li>addons/textfilter/ui.rc <span style="color: grey">(d8bd7eb)</span></li>
<li>addons/xmlcheck/ui.rc <span style="color: grey">(ae993b7)</span></li>
<li>addons/xmltools/ui.rc <span style="color: grey">(08e5fb8)</span></li>
<li>kate/data/kateui.rc <span style="color: grey">(dc5ea8a)</span></li>
<li>addons/katebuild-plugin/ui.rc <span style="color: grey">(0d6e79f)</span></li>
<li>addons/katesql/ui.rc <span style="color: grey">(9fde7f6)</span></li>
<li>addons/konsole/ui.rc <span style="color: grey">(3499c0d)</span></li>
<li>addons/kttsd/ui.rc <span style="color: grey">(1472ce7)</span></li>
<li>addons/filetree/ui.rc <span style="color: grey">(5f515e7)</span></li>
<li>addons/gdbplugin/ui.rc <span style="color: grey">(dfe6cd0)</span></li>
<li>addons/kate-ctags/ui.rc <span style="color: grey">(c3e957a)</span></li>
<li>addons/close-except-like/ui.rc <span style="color: grey">(8b11ebd)</span></li>
<li>addons/filetemplates/plugin/ui.rc <span style="color: \
grey">(1b7ebea)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121249/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3636211074147904809==--
_______________________________________________
KWrite-Devel mailing list
KWrite-Devel@kde.org
https://mail.kde.org/mailman/listinfo/kwrite-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic