[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kwin
Subject:    Re: bug in coverswitch starting animation
From:       Martin Graesslin <ubuntu () martin-graesslin ! com>
Date:       2008-06-02 21:13:54
Message-ID: 200806022314.01529.ubuntu () martin-graesslin ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Thanks for the hint. I have never concidered this as a bug ;-) The problem is 
that internally the window is switched as soon as you press alt+tab. So I just 
worked around it ;-) Only shift key has no effect. It's the same as without, 
but I think that's ok.

Please try it and tell me if it solves the issue for "3D-Fenstergalerie".

Regards Martin

On Monday 02 June 2008 21:09:50 Sebastian Kuegler wrote:
> I've just discovered this bug in coverswitch:
>
> When starting the effect, the following happens: The windows are switched
> immediately on keypress, then the starting animation comes. That kind of
> destroys the purpose of the beginning animations.
> It should be as follows: The effect is started, when they keys are
> released, windows should be switched.
>
> Martin, can you have a look at this? With the current list of things I've
> on my notes plasmoids, I'm doubtful it won't happen soon :/I've just
> discovered this bug in coverswitch:
>
> When starting the effect, the following happens: The windows are switched
> immediately on keypress, then the starting animation comes. That kind of
> destroys the purpose of the beginning animations.
> It should be as follows: The effect is started, when they keys are
> released, windows should be switched.
>
> Martin (or anyone else loving kwin), can you have a look at this? With the
> current list of things I've on my notes plasmoids, I'm doubtful it won't
> happen soon :/
>
> Cheers,


["coverswitch.diff" (text/x-patch)]

Index: coverswitch.cpp
===================================================================
--- coverswitch.cpp	(revision 815925)
+++ coverswitch.cpp	(working copy)
@@ -574,9 +574,11 @@
                 effects->setActiveFullScreenEffect( this );
                 selectedWindow = \
effects->currentTabBoxWindowList().indexOf(effects->currentTabBoxWindow());  \
mActivated = true; +                forward = true;
                 if( animateStart )
                     {
                     start = true;
+                    rearrangeWindows = -1;
                     }
 
                 // Calculation of correct area
@@ -608,10 +610,11 @@
                 {
                 stop = true;
                 }
-            else if( start && rearrangeWindows == 0 )
+            else if( start && rearrangeWindows == -1 )
                 {
                 start = false;
                 stop = true;
+                rearrangeWindows = 0;
                 timeLine.setProgress( 1.0 - timeLine.value() );
                 }
             else


["signature.asc" (application/pgp-signature)]

_______________________________________________
kwin mailing list
kwin@kde.org
https://mail.kde.org/mailman/listinfo/kwin


[prev in list] [next in list] [prev in thread] [next in thread]