[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: KDChart::Legend bug: incorrect brushes used when datasets are
From:       Dag Andersen <danders () get2net ! dk>
Date:       2010-06-29 12:04:03
Message-ID: 201006291404.03864.danders () get2net ! dk
[Download RAW message or body]

Mandag 28 juni 2010 18:44:23 skrev Sebastian Sauer:
> Dag Andersen wrote:
> > In Legend::buildLegend() hidden datasets are not taken into account when
> > brushes are fetched.
> > I suspect it is the the same with pens and markers also but I haven't
> > tested that.
> 
> Afaik yes, it's the same with brushes and pens. iirc the problem here was
>  that multiple dimensions where not handled correct. That was fixed later
>  and it seems the fix that also addresses this issue is rather big and
>  touches lot of lines. But probably Johannes can answer it more detailed if
>  he likes cause it seems he fixed it :)
> 
> > What I do is creating a clean legend and set a diagram that has a source
> > model that returns a brush for all (6) datasets. When all datasets are
> > shown, I get the correct brushes. My expectation is that when I hide e.g.
> > dataset 0, 1 and 2, I should get the brushes for dataset 3, 4,and 5.
> > Instead I get brushes for 1, 2 and 3.
> >
> > The pacth fixes this, but as I said  I suspect pens and markers also, and
> > there is so many defaults and fall-backs that I might have missed a trick
> > or two.
> 
> I would suggest to apply that patch asap to koffice/kdchart/kdchart/* to
>  get right of the prob for now. Since it's fixed in 2.4.0 it will not make
>  a difference once we merge 2.4.0.
Hope it is soon :)
> 
> I am not sure re the crash-fix yet. Guess I need some more time to
>  understand what the prob is. But just like before I would suggest to
>  commit first and review later.
Done.
-- 
Mvh.
Dag Andersen
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]