[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: FreOffice Viewer to FreOffice Editor
From:       "pratik vyas" <pratikvyas10 () gmail ! com>
Date:       2010-06-29 12:04:29
Message-ID: 20100629120429.12340.53296 () localhost
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4445/
-----------------------------------------------------------

(Updated 2010-06-29 12:04:29.643588)


Review request for KOffice.


Changes
-------

changes suggested by amit is done here


Summary
-------

We have provided following functionality in freoffice viewer to make editing enable.

Description:-

 Basic Editing :-
 	we have extended the functionality by adding the editing feature 
	in FreOffice. Now the user can open a new Text Document and write text in 
	it or he/she can open and edit document. It provides more usability to the 
	user as now he can make changes in the document on move. User Interface 
	is designed keeping in view that user gets required tool in minimum number 
	of clicks. 

       1.UI Development includes following :-
	      Edit ToolBar
	      Format Options Frame
	      Font Options Frame
	      Main Menu Modification
   
      2. New Functionality added in main menu
              Save 
              SaveAs
              Close
     
      3. Following are the Edit Tool Bar options that we have enable for word document : 
   	 Bold 
   	 Italic 
   	 Underline 
   	 Cut 
   	 Copy 
   	 Paste 
   	 Undo
   	 Redo
   	 Insert Options:- 
         	 Font Style 
          	 Font Size 
          	 Text Color 
         	 Subscript 
          	 Superscript 
                                         
	 Format Options:- 
     	         Bold 
     	         Italic 
	         Underline 
     	         Align left 
     	         Align Right 
     	         Align Center 
                 Align Justify 
     	         Bullets 
     	         Numbers 

       4  In Presenter Part user can edit existing presention and save it in odp or ppt format 

Here i have attached patch ,please kindly review the new changes.


This addresses bugs Editor, FreOfficeViewer and to.
    https://bugs.kde.org/show_bug.cgi?id=Editor
    https://bugs.kde.org/show_bug.cgi?id=FreOfficeViewer
    https://bugs.kde.org/show_bug.cgi?id=to


Diffs (updated)
-----

  /trunk/koffice/tools/f-office/CMakeLists.txt 1138588 
  /trunk/koffice/tools/f-office/Common.h 1138588 
  /trunk/koffice/tools/f-office/FreOffice.desktop 1138588 
  /trunk/koffice/tools/f-office/FreOffice.qrc 1138588 
  /trunk/koffice/tools/f-office/MainWindow.h 1138588 
  /trunk/koffice/tools/f-office/MainWindow.cpp 1138588 
  /trunk/koffice/tools/f-office/MainWindow.ui 1138588 

Diff: http://reviewboard.kde.org/r/4445/diff


Testing
-------

We have check functionality all use cases that is newly added 
Testing for memory leaks has been done by valgrind


Thanks,

pratik


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard.kde.org/r/4445/">http://reviewboard.kde.org/r/4445/</a>
  </td>
    </tr>
   </table>
   <br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By pratik vyas.</div>


<p style="color: grey;"><i>Updated 2010-06-29 12:04:29.643588</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">changes suggested by amit is done here</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">We have provided following functionality in \
freoffice viewer to make editing enable.

Description:-

 Basic Editing :-
 	we have extended the functionality by adding the editing feature 
	in FreOffice. Now the user can open a new Text Document and write text in 
	it or he/she can open and edit document. It provides more usability to the 
	user as now he can make changes in the document on move. User Interface 
	is designed keeping in view that user gets required tool in minimum number 
	of clicks. 

       1.UI Development includes following :-
	      Edit ToolBar
	      Format Options Frame
	      Font Options Frame
	      Main Menu Modification
   
      2. New Functionality added in main menu
              Save 
              SaveAs
              Close
     
      3. Following are the Edit Tool Bar options that we have enable for word \
document :   Bold 
   	 Italic 
   	 Underline 
   	 Cut 
   	 Copy 
   	 Paste 
   	 Undo
   	 Redo
   	 Insert Options:- 
         	 Font Style 
          	 Font Size 
          	 Text Color 
         	 Subscript 
          	 Superscript 
                                         
	 Format Options:- 
     	         Bold 
     	         Italic 
	         Underline 
     	         Align left 
     	         Align Right 
     	         Align Center 
                 Align Justify 
     	         Bullets 
     	         Numbers 

       4  In Presenter Part user can edit existing presention and save it in odp or \
ppt format 

Here i have attached patch ,please kindly review the new changes.</pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0;">We have check functionality all use cases that \
is newly added  Testing for memory leaks has been done by valgrind</pre>
  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=Editor">Editor</a>, 

 <a href="https://bugs.kde.org/show_bug.cgi?id=FreOfficeViewer">FreOfficeViewer</a>, 

 <a href="https://bugs.kde.org/show_bug.cgi?id=to">to</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/koffice/tools/f-office/CMakeLists.txt <span style="color: \
grey">(1138588)</span></li>

 <li>/trunk/koffice/tools/f-office/Common.h <span style="color: \
grey">(1138588)</span></li>

 <li>/trunk/koffice/tools/f-office/FreOffice.desktop <span style="color: \
grey">(1138588)</span></li>

 <li>/trunk/koffice/tools/f-office/FreOffice.qrc <span style="color: \
grey">(1138588)</span></li>

 <li>/trunk/koffice/tools/f-office/MainWindow.h <span style="color: \
grey">(1138588)</span></li>

 <li>/trunk/koffice/tools/f-office/MainWindow.cpp <span style="color: \
grey">(1138588)</span></li>

 <li>/trunk/koffice/tools/f-office/MainWindow.ui <span style="color: \
grey">(1138588)</span></li>

</ul>

<p><a href="http://reviewboard.kde.org/r/4445/diff/" style="margin-left: 3em;">View \
Diff</a></p>




  </td>
 </tr>
</table>




  </div>
 </body>
</html>



_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic