[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-pim
Subject:    [Kde-pim] Review Request: Reuse QString instances in parseAddrList
From:       "Milian Wolff" <mail () milianw ! de>
Date:       2012-10-13 20:06:54
Message-ID: 20121013200654.25223.15045 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106836/
-----------------------------------------------------------

Review request for KDEPIM and KDEPIM-Libraries.


Description
-------

Leverage QString implicit sharing to reduce memory consumption. In my tests, the \
memory decreases roughly by ~20MB from a total of 300 down to about 280MB.

My question is rather, whether this really needs to be thread safe or not. Maybe also \
some performance testing is required?


Diffs
-----

  plugins/akonadi_serializer_mail.h cf43949 
  plugins/akonadi_serializer_mail.cpp 096073a 

Diff: http://git.reviewboard.kde.org/r/106836/diff/


Testing
-------

Ran KMail, not noticeably slower but uses less ram. Nothing else seems to have \
changed.


Thanks,

Milian Wolff

_______________________________________________
KDE PIM mailing list kde-pim@kde.org
https://mail.kde.org/mailman/listinfo/kde-pim
KDE PIM home page at http://pim.kde.org/


[prev in list] [next in list] [prev in thread] [next in thread]