From kde-pim Sat Oct 13 20:06:54 2012 From: "Milian Wolff" Date: Sat, 13 Oct 2012 20:06:54 +0000 To: kde-pim Subject: [Kde-pim] Review Request: Reuse QString instances in parseAddrList Message-Id: <20121013200654.25223.15045 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=kde-pim&m=135015882811085 ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106836/ ----------------------------------------------------------- Review request for KDEPIM and KDEPIM-Libraries. Description ------- Leverage QString implicit sharing to reduce memory consumption. In my tests, the memory decreases roughly by ~20MB from a total of 300 down to about 280MB. My question is rather, whether this really needs to be thread safe or not. Maybe also some performance testing is required? Diffs ----- plugins/akonadi_serializer_mail.h cf43949 plugins/akonadi_serializer_mail.cpp 096073a Diff: http://git.reviewboard.kde.org/r/106836/diff/ Testing ------- Ran KMail, not noticeably slower but uses less ram. Nothing else seems to have changed. Thanks, Milian Wolff _______________________________________________ KDE PIM mailing list kde-pim@kde.org https://mail.kde.org/mailman/listinfo/kde-pim KDE PIM home page at http://pim.kde.org/