[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 114910: Patch for bug 317066 ("systray leaves garbage on the panel when resizing
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2014-07-29 20:50:46
Message-ID: 20140729205046.15440.7718 () probe ! kde ! org
[Download RAW message or body]
--===============4480730772215632570==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On jul. 29, 2014, 5:12 p.m., Marco Martin wrote:
> > Ship It!
Marco, Dmitry doesn't have an account, can you please push this to 4.11?
- Albert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114910/#review63466
-----------------------------------------------------------
On gen. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114910/
> -----------------------------------------------------------
>
> (Updated gen. 8, 2014, 4:25 p.m.)
>
>
> Review request for kde-workspace and Plasma.
>
>
> Bugs: 317066
> http://bugs.kde.org/show_bug.cgi?id=317066
>
>
> Repository: kde-workspace
>
>
> Description
> -------
>
> It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode \
> for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it \
> efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary \
> (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer \
> reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose \
> is acceptable since it may seem like a hack to more experienced developers, however I just didn't want \
> my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the \
> patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you.
>
> Diffs
> -----
>
> plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d
>
> Diff: https://git.reviewboard.kde.org/r/114910/diff/
>
>
> Testing
> -------
>
> I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on \
> Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any \
> noticeable performance problems of system tray applet.
>
> Thanks,
>
> Dmitry Ivanov
>
>
--===============4480730772215632570==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114910/">https://git.reviewboard.kde.org/r/114910/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On juliol 29th, 2014, 5:12 p.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Ship It!</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: \
-o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Marco, Dmitry doesn't have an account, can you please push this to \
4.11?</p></pre> <br />
<p>- Albert</p>
<br />
<p>On gener 8th, 2014, 4:25 p.m. UTC, Dmitry Ivanov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for kde-workspace and Plasma.</div>
<div>By Dmitry Ivanov.</div>
<p style="color: grey;"><i>Updated gen. 8, 2014, 4:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=317066">317066</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It is a proposed fix for bug 317066. The fix \
is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware \
FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any \
graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). \
I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see \
any noticeable performance problems. I'm still not sure what I propose is acceptable since it may \
seem like a hack to more experienced developers, however I just didn't want my patch attempt to get \
lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be \
applied to the next bugfixing release of KDE 4.x series, thank you. < /pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I rebuilt plasma_applet_systemtray.so with \
the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So \
far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of \
system tray applet. </pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp <span style="color: \
grey">(1baa23d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114910/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4480730772215632570==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic