--===============7216153800781956294== Content-Type: multipart/alternative; boundary="===============4480730772215632570==" --===============4480730772215632570== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On jul. 29, 2014, 5:12 p.m., Marco Martin wrote: > > Ship It! Marco, Dmitry doesn't have an account, can you please push this to 4.11? - Albert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/#review63466 ----------------------------------------------------------- On gen. 8, 2014, 4:25 p.m., Dmitry Ivanov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114910/ > ----------------------------------------------------------- > > (Updated gen. 8, 2014, 4:25 p.m.) > > > Review request for kde-workspace and Plasma. > > > Bugs: 317066 > http://bugs.kde.org/show_bug.cgi?id=317066 > > > Repository: kde-workspace > > > Description > ------- > > It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. > > > Diffs > ----- > > plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp 1baa23d > > Diff: https://git.reviewboard.kde.org/r/114910/diff/ > > > Testing > ------- > > I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet. > > > Thanks, > > Dmitry Ivanov > > --===============4480730772215632570== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114910/

On juliol 29th, 2014, 5:12 p.m. UTC, Marco Martin wrote:
Ship It!

Marco, Dmitry doesn't have an account, can you please push this to 4.11?

- Albert

On gener 8th, 2014, 4:25 p.m. UTC, Dmitry Ivanov wrote:

Review request for kde-workspace and Plasma.

By Dmitry Ivanov.

Updated gen. 8, 2014, 4:25 p.m.

Bugs: 317066

Repository: kde-workspace

Description

It is a proposed fix for bug 317066. The fix is a very simple one-liner setting FullViewportUpdate mode for FdoGraphicsWidget. I'm aware FullViewportUpdate has negative performance impact but I also know it efficiently leaves out any graphical glitches happening due to no repaint of widget when necessary (which is what the bug is about). I have tested my solution for a couple of days: the bug no longer reproduced and I also didn't see any noticeable performance problems. I'm still not sure what I propose is acceptable since it may seem like a hack to more experienced developers, however I just didn't want my patch attempt to get lost and forgotten in the bugzilla. Please have a look and decide whether the patch is good enough to be applied to the next bugfixing release of KDE 4.x series, thank you. <
 /pre>

Testing

I rebuilt plasma_applet_systemtray.so with the patch and replaced the package version with it (I'm on Linux Mint 16 KDE, x86_64, KDE 4.11.3). So far I can no longer reproduce bug 317066 and I don't see any noticeable performance problems of system tray applet.

Diffs

plasma/generic/applets/systemtray/protocols/fdo/fdographicswidget.cpp (1baa23d)

--===============4480730772215632570==-- --===============7216153800781956294== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7216153800781956294==--