'Re: [Kde-hardware-devel] Review Request 119834: Don't report gphoto devices that are child of gphoto'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-hardware-devel
Subject:    Re: [Kde-hardware-devel] Review Request 119834: Don't report gphoto devices that are child of gphoto
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2014-09-29 20:15:26
Message-ID: 20140929201526.15676.67669 () probe ! kde ! org
[Download RAW message or body]

--===============0544057810537953207==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119834/#review67650
-----------------------------------------------------------

ping

- Albert Astals Cid

On ago. 18, 2014, 10:14 p.m., Albert Astals Cid wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119834/
> -----------------------------------------------------------
> 
> (Updated ago. 18, 2014, 10:14 p.m.)
> 
> 
> Review request for Solid, Àlex Fiestas and Lukáš Tinkl.
> 
> 
> Repository: kdelibs
> 
> 
> Description
> -------
> 
> When pluggin in my camera i get two cameras in the device notifier, seems udev \
> returns twice see http://paste.kde.org/prbu43pgo and http://paste.kde.org/poh8hutaj \
>  So I decided that it made no sense to report gphoto devices that are child of \
> another gphoto device. 
> This may be a totally broken assumption. Other ways to fix the issue accepted.
> 
> 
> Diffs
> -----
> 
> solid/solid/backends/udev/udevmanager.cpp 1f6369f 
> 
> Diff: https://git.reviewboard.kde.org/r/119834/diff/
> 
> 
> Testing
> -------
> 
> Now my camera shows up only once.
> 
> 
> Thanks,
> 
> Albert Astals Cid
> 
> 

--===============0544057810537953207==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119834/">https://git.reviewboard.kde.org/r/119834/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">ping</p></pre>  <br />

<p>- Albert Astals Cid</p>

<br />
<p>On agost 18th, 2014, 10:14 p.m. UTC, Albert Astals Cid wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Solid, Àlex Fiestas and Lukáš Tinkl.</div>
<div>By Albert Astals Cid.</div>

<p style="color: grey;"><i>Updated ago. 18, 2014, 10:14 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When pluggin in my camera i get two cameras in the \
device notifier, seems udev returns twice see http://paste.kde.org/prbu43pgo and \
http://paste.kde.org/poh8hutaj</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">So I decided that it \
made no sense to report gphoto devices that are child of another gphoto device.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This may be a totally broken assumption. Other ways to \
fix the issue accepted.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Now my camera shows up only once.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>solid/solid/backends/udev/udevmanager.cpp <span style="color: \
grey">(1f6369f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119834/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0544057810537953207==--

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel

[prev in list] [next in list] [prev in thread] [next in thread] 