[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-hardware-devel
Subject: Re: [Kde-hardware-devel] Review Request 119822: QScreen backend for libkscreen
From: Sebastian_Kügler <sebas () kde ! org>
Date: 2014-09-14 22:16:58
Message-ID: 20140914221658.22585.12642 () probe ! kde ! org
[Download RAW message or body]
--===============0464317548831197558==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119822/
-----------------------------------------------------------
(Updated Sept. 14, 2014, 10:16 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma and Solid.
Repository: libkscreen
Description
-------
This patch adds a QScreen backend to libkscreen.
This is useful to avoid a dependency on XRandR (at build time) and a running X server \
at runtime.
The backend itself is read-only and kept simple. It only reports the basic \
necessities (which is what QScreen provides).
The changes are kept to the backends/qscreen directory, so no API has been touched. \
The changes outside of that directory are autotests, tests, and a fallback to the \
qscreen backend non non-X11 platforms. The latter will automatically make libkscreen \
work on Wayland (as far as QScreen allows us to, so r-o). This case otherwise just \
crashes, and the XRandR backend can't work. If the user specifies the backend using \
the KSCREEN_BACKEND env var, it will be respected, the automatism only triggers when \
no backend is explicitely specified. I've also added apidocs in some files, but \
again, no functional changes.
The plan is to augment this also with a native Wayland backend, which will take a bit \
longer to complete (more complex, it's r-w, I have to learn Wayland APIs). That \
backend is work-in-progress in the sebas/wayland branch. The QScreen backend allows \
us to test and run our code under Wayland, without crashing, so we can continue the \
port while a native Wayland backend is conceived.
You can find the code for this QScreen backend in sebas/qscreen if you'd like to give \
it a try.
Diffs
-----
tests/testplugandplay.cpp PRE-CREATION
tests/testpnp.h PRE-CREATION
tests/testpnp.cpp PRE-CREATION
autotests/CMakeLists.txt 18b93c0
autotests/testqscreenbackend.cpp PRE-CREATION
backends/CMakeLists.txt a827ee8
backends/abstractbackend.h 7ffe627
backends/qscreen/CMakeLists.txt PRE-CREATION
backends/qscreen/qscreenbackend.h PRE-CREATION
backends/qscreen/qscreenbackend.cpp PRE-CREATION
backends/qscreen/qscreenconfig.h PRE-CREATION
backends/qscreen/qscreenconfig.cpp PRE-CREATION
backends/qscreen/qscreenoutput.h PRE-CREATION
backends/qscreen/qscreenoutput.cpp PRE-CREATION
src/CMakeLists.txt 4606862
src/backendloader.cpp d6ccdff
src/config.h 10a8f1e
tests/CMakeLists.txt 86efedc
tests/printconfig.cpp 249f123
backends/qscreen/qscreenscreen.h PRE-CREATION
backends/qscreen/qscreenscreen.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/119822/diff/
Testing
-------
* Ran autotest "testqscreenbackend" under X11 and Wayland -- all pass
* Tested hotplugging (using included testpnp app) under X11
* Started plasmashell with KSCREEN_BACKEND=QScreen under X11
* Started kcmshell5 kcm_kscreen
All of these work correctly in my tests, no strange behaviour observed.
Thanks,
Sebastian Kügler
--===============0464317548831197558==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119822/">https://git.reviewboard.kde.org/r/119822/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and Solid.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated Sept. 14, 2014, 10:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch adds a QScreen backend to libkscreen.</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is useful to avoid a dependency on XRandR (at \
build time) and a running X server at runtime.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
backend itself is read-only and kept simple. It only reports the basic necessities \
(which is what QScreen provides).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">The changes are kept to \
the backends/qscreen directory, so no API has been touched. The changes outside of \
that directory are autotests, tests, and a fallback to the qscreen backend non \
non-X11 platforms. The latter will automatically make libkscreen work on Wayland (as \
far as QScreen allows us to, so r-o). This case otherwise just crashes, and the \
XRandR backend can't work. If the user specifies the backend using the \
KSCREEN_BACKEND env var, it will be respected, the automatism only triggers when no \
backend is explicitely specified. I've also added apidocs in some files, but again, \
no functional changes.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">The plan is to augment this also with a \
native Wayland backend, which will take a bit longer to complete (more complex, it's \
r-w, I have to learn Wayland APIs). That backend is work-in-progress in the \
sebas/wayland branch. The QScreen backend allows us to test and run our code under \
Wayland, without crashing, so we can continue the port while a native Wayland backend \
is conceived.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">You can find the code for this QScreen backend in \
sebas/qscreen if you'd like to give it a try.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">Ran autotest \
"testqscreenbackend" under X11 and Wayland -- all pass</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Tested \
hotplugging (using included testpnp app) under X11</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Started plasmashell with KSCREEN_BACKEND=QScreen under X11</li> <li \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">Started kcmshell5 kcm_kscreen</li> </ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">All of these work correctly in my tests, no strange \
behaviour observed.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>tests/testplugandplay.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/testpnp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/testpnp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(18b93c0)</span></li>
<li>autotests/testqscreenbackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/CMakeLists.txt <span style="color: grey">(a827ee8)</span></li>
<li>backends/abstractbackend.h <span style="color: grey">(7ffe627)</span></li>
<li>backends/qscreen/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenbackend.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenbackend.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenconfig.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenconfig.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenoutput.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenoutput.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(4606862)</span></li>
<li>src/backendloader.cpp <span style="color: grey">(d6ccdff)</span></li>
<li>src/config.h <span style="color: grey">(10a8f1e)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(86efedc)</span></li>
<li>tests/printconfig.cpp <span style="color: grey">(249f123)</span></li>
<li>backends/qscreen/qscreenscreen.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>backends/qscreen/qscreenscreen.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119822/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0464317548831197558==--
_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic