[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 121090: Move kio-mtp to kio-extras
From: "David Faure" <faure () kde ! org>
Date: 2014-11-13 17:55:15
Message-ID: 20141113175515.2121.15254 () probe ! kde ! org
[Download RAW message or body]
--===============8235570707158233171==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Nov. 12, 2014, 10:04 p.m., Àlex Fiestas wrote:
> > I would move this perhaps to plasma-workspace since this slave is really \
> > important for nowadays usage of the desktop (android phones etc).
>
> Aleix Pol Gonzalez wrote:
> Well, there's important kio's as well in kio-extras. Question is, is it useful \
> outside the workspace? Would a cross-platform application use it?
> It seems to me they would, I can see amarok requiring it even on windows or gnome.
>
> Jan Grulich wrote:
> To me it makes more sense to have it in kio-extras with the rest of kioslaves.
plasma-workspace isn't about "importance". It's about what constitutes the pure \
desktop (a place where to show windows from applications). Actual functionality that \
would also work in other desktops and OSes (like dolphin, like kioslaves, and so on) \
belongs to Applications.
kio-extras being under kde/workspace right now is really a bug, that I've been \
pleading against since day one. Please please move it out of there, it's nonsense for \
it to be there. kioslaves work in other environments.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121090/#review70301
-----------------------------------------------------------
On Nov. 10, 2014, 9:30 a.m., Jan Grulich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121090/
> -----------------------------------------------------------
>
> (Updated Nov. 10, 2014, 9:30 a.m.)
>
>
> Review request for KDE Frameworks, David Faure and Philipp Schmidt.
>
>
> Repository: kio-extras
>
>
> Description
> -------
>
> This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that \
> this kioslave should be with the rest and not alone somewhere without release. I \
> also formatted it a bit to follow kdelibs coding style.
> Discussion about this move can be found here \
> http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2
>
> Diffs
> -----
>
> mtp/kio_mtp_helpers.h PRE-CREATION
> mtp/kio_mtp_helpers.cpp PRE-CREATION
> mtp/mtp-network.desktop PRE-CREATION
> mtp/mtp.protocol PRE-CREATION
> mtp/solid_mtp.desktop PRE-CREATION
> mtp/filecache.cpp PRE-CREATION
> mtp/kio-mtp.kdev4 PRE-CREATION
> mtp/kio_mtp.h PRE-CREATION
> mtp/kio_mtp.cpp PRE-CREATION
> CMakeLists.txt 8f82688
> mtp/CMakeLists.txt PRE-CREATION
> mtp/COPYING PRE-CREATION
> mtp/LICENCE PRE-CREATION
> mtp/Messages.sh PRE-CREATION
> mtp/README PRE-CREATION
> mtp/devicecache.h PRE-CREATION
> mtp/devicecache.cpp PRE-CREATION
> mtp/filecache.h PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/121090/diff/
>
>
> Testing
> -------
>
> I have tested copying files, creating and removing folders in Dolphin with my Nexus \
> 4 and everything seems to work fine.
>
> Thanks,
>
> Jan Grulich
>
>
--===============8235570707158233171==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121090/">https://git.reviewboard.kde.org/r/121090/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 12th, 2014, 10:04 p.m. UTC, <b>Àlex \
Fiestas</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I would move this perhaps to plasma-workspace since \
this slave is really important for nowadays usage of the desktop (android phones \
etc).</p></pre> </blockquote>
<p>On November 13th, 2014, 1:04 a.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, \
there's important kio's as well in kio-extras. Question is, is it useful outside the \
workspace? Would a cross-platform application use it?</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It \
seems to me they would, I can see amarok requiring it even on windows or \
gnome.</p></pre> </blockquote>
<p>On November 13th, 2014, 12:56 p.m. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To me \
it makes more sense to have it in kio-extras with the rest of kioslaves.</p></pre> \
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">plasma-workspace isn't about "importance". It's about what constitutes the \
pure desktop (a place where to show windows from applications). Actual functionality \
that would also work in other desktops and OSes (like dolphin, like kioslaves, and so \
on) belongs to Applications.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">kio-extras being under kde/workspace \
right now is really a bug, that I've been pleading against since day one. Please \
please move it out of there, it's nonsense for it to be there. kioslaves work in \
other environments.</p></pre> <br />
<p>- David</p>
<br />
<p>On November 10th, 2014, 9:30 a.m. UTC, Jan Grulich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, David Faure and Philipp Schmidt.</div>
<div>By Jan Grulich.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2014, 9:30 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio-extras
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch moves kio-mtp from its frameworks branch to \
kio-extras. I believe that this kioslave should be with the rest and not alone \
somewhere without release. I also formatted it a bit to follow kdelibs coding \
style.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Discussion about this move can be found here \
http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have tested copying files, creating and removing \
folders in Dolphin with my Nexus 4 and everything seems to work fine.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mtp/kio_mtp_helpers.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp_helpers.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/mtp-network.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/mtp.protocol <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/solid_mtp.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/filecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio-mtp.kdev4 <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/kio_mtp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(8f82688)</span></li>
<li>mtp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/COPYING <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/LICENCE <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/devicecache.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/devicecache.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>mtp/filecache.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121090/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============8235570707158233171==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic