From kde-frameworks-devel Thu Nov 13 17:55:15 2014 From: "David Faure" Date: Thu, 13 Nov 2014 17:55:15 +0000 To: kde-frameworks-devel Subject: Re: Review Request 121090: Move kio-mtp to kio-extras Message-Id: <20141113175515.2121.15254 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=141590134507802 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============5649206817731830296==" --===============5649206817731830296== Content-Type: multipart/alternative; boundary="===============8235570707158233171==" --===============8235570707158233171== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Nov. 12, 2014, 10:04 p.m., Àlex Fiestas wrote: > > I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc). > > Aleix Pol Gonzalez wrote: > Well, there's important kio's as well in kio-extras. Question is, is it useful outside the workspace? Would a cross-platform application use it? > > It seems to me they would, I can see amarok requiring it even on windows or gnome. > > Jan Grulich wrote: > To me it makes more sense to have it in kio-extras with the rest of kioslaves. plasma-workspace isn't about "importance". It's about what constitutes the pure desktop (a place where to show windows from applications). Actual functionality that would also work in other desktops and OSes (like dolphin, like kioslaves, and so on) belongs to Applications. kio-extras being under kde/workspace right now is really a bug, that I've been pleading against since day one. Please please move it out of there, it's nonsense for it to be there. kioslaves work in other environments. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/#review70301 ----------------------------------------------------------- On Nov. 10, 2014, 9:30 a.m., Jan Grulich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121090/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2014, 9:30 a.m.) > > > Review request for KDE Frameworks, David Faure and Philipp Schmidt. > > > Repository: kio-extras > > > Description > ------- > > This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style. > > Discussion about this move can be found here http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2 > > > Diffs > ----- > > mtp/kio_mtp_helpers.h PRE-CREATION > mtp/kio_mtp_helpers.cpp PRE-CREATION > mtp/mtp-network.desktop PRE-CREATION > mtp/mtp.protocol PRE-CREATION > mtp/solid_mtp.desktop PRE-CREATION > mtp/filecache.cpp PRE-CREATION > mtp/kio-mtp.kdev4 PRE-CREATION > mtp/kio_mtp.h PRE-CREATION > mtp/kio_mtp.cpp PRE-CREATION > CMakeLists.txt 8f82688 > mtp/CMakeLists.txt PRE-CREATION > mtp/COPYING PRE-CREATION > mtp/LICENCE PRE-CREATION > mtp/Messages.sh PRE-CREATION > mtp/README PRE-CREATION > mtp/devicecache.h PRE-CREATION > mtp/devicecache.cpp PRE-CREATION > mtp/filecache.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/121090/diff/ > > > Testing > ------- > > I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine. > > > Thanks, > > Jan Grulich > > --===============8235570707158233171== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/

On November 12th, 2014, 10:04 p.m. UTC, Àlex Fiestas wrote:

I would move this perhaps to plasma-workspace since this slave is really important for nowadays usage of the desktop (android phones etc).

On November 13th, 2014, 1:04 a.m. UTC, Aleix Pol Gonzalez wrote:

Well, there's important kio's as well in kio-extras. Question is, is it useful outside the workspace? Would a cross-platform application use it?


It seems to me they would, I can see amarok requiring it even on windows or gnome.

On November 13th, 2014, 12:56 p.m. UTC, Jan Grulich wrote:

To me it makes more sense to have it in kio-extras with the rest of kioslaves.
plasma-workspace isn't about "importance". It's about what constitutes the pure desktop (a place where to show windows from applications). Actual functionality that would also work in other desktops and OSes (like dolphin, like kioslaves, and so on) belongs to Applications.


kio-extras being under kde/workspace right now is really a bug, that I've been pleading against since day one. Please please move it out of there, it's nonsense for it to be there. kioslaves work in other environments.

- David


On November 10th, 2014, 9:30 a.m. UTC, Jan Grulich wrote:

Review request for KDE Frameworks, David Faure and Philipp Schmidt.
By Jan Grulich.

Updated Nov. 10, 2014, 9:30 a.m.

Repository: kio-extras

Description 

This patch moves kio-mtp from its frameworks branch to kio-extras. I believe that this kioslave should be with the rest and not alone somewhere without release. I also formatted it a bit to follow kdelibs coding style.


Discussion about this move can be found here http://lists.kde.org/?l=kde-devel&m=141500903106761&w=2

Testing 

I have tested copying files, creating and removing folders in Dolphin with my Nexus 4 and everything seems to work fine.

Diffs

  • mtp/kio_mtp_helpers.h (PRE-CREATION)
  • mtp/kio_mtp_helpers.cpp (PRE-CREATION)
  • mtp/mtp-network.desktop (PRE-CREATION)
  • mtp/mtp.protocol (PRE-CREATION)
  • mtp/solid_mtp.desktop (PRE-CREATION)
  • mtp/filecache.cpp (PRE-CREATION)
  • mtp/kio-mtp.kdev4 (PRE-CREATION)
  • mtp/kio_mtp.h (PRE-CREATION)
  • mtp/kio_mtp.cpp (PRE-CREATION)
  • CMakeLists.txt (8f82688)
  • mtp/CMakeLists.txt (PRE-CREATION)
  • mtp/COPYING (PRE-CREATION)
  • mtp/LICENCE (PRE-CREATION)
  • mtp/Messages.sh (PRE-CREATION)
  • mtp/README (PRE-CREATION)
  • mtp/devicecache.h (PRE-CREATION)
  • mtp/devicecache.cpp (PRE-CREATION)
  • mtp/filecache.h (PRE-CREATION)

View Diff
--===============8235570707158233171==-- --===============5649206817731830296== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============5649206817731830296==--