[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Breeze widget style for KF5
From:       Andrew Lake <jamboarder () gmail ! com>
Date:       2014-08-11 16:11:43
Message-ID: CAKFiHE-Oat__Yy+tE0FJ=jSWKitE5XhPTbyBL=oakwUGpbG=7A () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi Hugo,

This is fantastic! I'm so excited to see how far your efforts have
progressed.

On Mon, Aug 11, 2014 at 3:29 AM, Hugo Pereira Da Costa  wrote:

> Ultimately I'd like to
> - push this to some official repository (where should that be ?
> kde/workspace/breeze/kstyle ?)
>

I'm ambivalent on where this is housed. You're certainly welcome to push it
to the Breeze project repo (widgetstyles/kstyle) if there's no consensus on
where to house it.

- make it the 'official' kf5 style (instead of the current QtCurve settings)
>

No objections from the VDG corner of course. :-)


>  - have feedback
>

I only have one or two questions. Generally though, this appears to be
quite a faithful implementation of Breeze UI controls design captured in
the QtQuick implementation.
- What corner radius is that? It looks a touch larger than I remember. They
might need to be a touch sharper everywhere (maybe round down instead of up
on corner radii?).
- If it's not too much trouble, we can eliminate the box around the header (
http://wstaw.org/m/2014/08/11/dolphin.png).
- The tabs look great. :-)
- The circular slider looks awesome (
http://wstaw.org/m/2014/08/11/oxygen-demo2.png). :-)
- We (the VDG) will likely need to revisit the progress bar design since we
didn't account for the % label which currently moves it off-center. We'll
work on that and deliver an updated design that considers that. For now,
it's fine as is.
- I know this'll seem like a nit-pick, but is it possible to have the ends
of the slider and the progress bar have a similar margin so they share the
same alignment line (http://wstaw.org/m/2014/08/11/oxygen-demo2.png)? I
completely understand why they look that way right now functionally, but
this tweak would be primarily for visual not functional reasons. I'll need
update the QtQuick implementation as well.
- There may be one or two other very minor things, but I'll wait till you
find a home for this and start ironing out any outstanding issues.
- Overall it looks fantastic!



>
> Among the things that are most notably missing are: a configuration ui (!)
> (though I foresee less things to be configurable than with oxygen)
>
> ... and then I'd like to:
> - make a gtk style
> - possibly make a kde4/qt4 style,
> - backport the improvement made to the code base (it is always good to
> revisit one's code) to oxygen@kf5
> etc.
>

+1. I don't have much to recommend for configuration right now so, unless
there are accessibility-related config stuff, I'd be ok if you decided that
the config is relatively lower priority compared to the other stuff here.


>
Wow. Super-excited by this Hugo! just holler if you have any questions from
the VDG side of things.

Much much respect,
Andrew

[Attachment #5 (text/html)]

<div dir="ltr">Hi Hugo,<div><br></div><div>This is fantastic! I&#39;m so excited to \
see how far your efforts have progressed.</div><div><br></div><div>On Mon, Aug 11, \
2014 at 3:29 AM, Hugo Pereira Da Costa   wrote:<br></div>

<div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
  

    
  
  <div text="#000000" bgcolor="#FFFFFF">Ultimately I&#39;d like to <br>
    - push this to some official repository (where should that be ?
    kde/workspace/breeze/kstyle ?)<br></div></blockquote><div><br></div><div>I&#39;m \
ambivalent on where this is housed. You&#39;re certainly welcome to push it to the \
Breeze project repo (widgetstyles/kstyle)  if there&#39;s no consensus on where to \
house it.</div>

<div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
                text="#000000" bgcolor="#FFFFFF">
    - make it the &#39;official&#39; kf5 style (instead of the current QtCurve
    settings)<br></div></blockquote><div><br></div><div>No objections from the VDG \
corner of course. :-)</div><div>  </div><blockquote class="gmail_quote" \
style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">


<div text="#000000" bgcolor="#FFFFFF">
    - have feedback<br></div></blockquote><div><br></div><div>I only have one or two \
questions. Generally though, this appears to be quite a faithful implementation of \
Breeze UI controls design captured in the QtQuick implementation.</div>

<div>- What corner radius is that? It looks a touch larger than I remember. They \
might need to be a touch sharper everywhere (maybe round down instead of up on corner \
radii?).</div><div>- If it&#39;s not too much trouble, we can eliminate the box \
around the header (<a \
href="http://wstaw.org/m/2014/08/11/dolphin.png">http://wstaw.org/m/2014/08/11/dolphin.png</a>).</div>


<div>- The tabs look great. :-)</div><div>- The circular slider looks awesome (<a \
href="http://wstaw.org/m/2014/08/11/oxygen-demo2.png">http://wstaw.org/m/2014/08/11/oxygen-demo2.png</a>). \
:-)</div><div>- We (the VDG) will likely need to revisit the progress bar design \
since we didn&#39;t account for the % label which currently moves it off-center. \
We&#39;ll work on that and deliver an updated design that considers that. For now, \
it&#39;s fine as is.</div>

<div>- I know this&#39;ll seem like a nit-pick, but is it possible to have the ends \
of the slider and the progress bar have a similar margin so they share the same \
alignment line (<a href="http://wstaw.org/m/2014/08/11/oxygen-demo2.png">http://wstaw.org/m/2014/08/11/oxygen-demo2.png</a>)? \
I completely understand why they look that way right now functionally, but this tweak \
would be primarily for visual not functional reasons. I&#39;ll need update the \
QtQuick implementation as well.</div>

<div>- There may be one or two other very minor things, but I&#39;ll wait till you \
find a home for this and start ironing out any outstanding issues.</div><div>- \
Overall it looks fantastic!</div><div><br></div><div>  </div>

<blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
text="#000000" bgcolor="#FFFFFF">  <br>
    Among the things that are most notably missing are: a configuration
    ui (!)<br>
    (though I foresee less things to be configurable than with oxygen)<br>
    <br>
    ... and then I&#39;d like to:<br>
    - make a gtk style<br>
    - possibly make a kde4/qt4 style, <br>
    - backport the improvement made to the code base (it is always good
    to revisit one&#39;s code) to oxygen@kf5<br>
    etc. <br></div></blockquote><div><br></div><div>+1. I don&#39;t have much to \
recommend for configuration right now so, unless there are accessibility-related \
config stuff, I&#39;d be ok if you decided that the config is relatively lower \
priority compared to the other stuff here.</div>

<div>  </div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div \
text="#000000" bgcolor="#FFFFFF">  </div></blockquote></div><br></div><div \
class="gmail_extra">Wow. Super-excited by this Hugo! just holler if you have any \
questions from the VDG side of things.</div><div class="gmail_extra"><br></div><div \
class="gmail_extra">

Much much respect,</div><div class="gmail_extra">Andrew</div></div>



_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic