'Re: Review Request 119713: Don't use hicolor if we have breeze or oxygen are available'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 119713: Don't use hicolor if we have breeze or oxygen are available
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2014-08-11 16:15:03
Message-ID: 20140811161503.14668.94225 () probe ! kde ! org
[Download RAW message or body]

--===============3956961689454367106==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119713/
-----------------------------------------------------------

(Updated ago. 11, 2014, 4:15 p.m.)

Review request for KDE Frameworks.

Repository: kconfigwidgets

Description (updated)
-------

I am running KGeography in a user which has oxygen icons available but since i'm not \
running neither the kde QPT nor oxygen style nor anything, while moving from KIcon to \
QIcon::fromTheme i lost most of my icons (since there is no kiconloader in the middle \
anymore), and the same for kstandardaction icons.

This patch makes it so that if you are using kstandardactions and your icon theme is \
hicolor but you have breeze or oxygen installed it changes the theme to one of those.

I am unconvinced if we want this here or if i want this in my (and potentially) every \
application so when we run in Gnome or Unity, our apps get icons what were getting in \
kde4 times because they were using KIcon and they would lose now because of the \
QIcon::fromTheme recommendation.

Obviously the missing icons also get fixed by QT_QPA_PLATFORMTHEME=kde but one can \
not expect to have this define when on non Plasma desktops and since in the past \
KIcon gave you oxygen-icons even if you were not on plasma i think it makes sense to \
do this.

Diffs
-----

  src/kstandardaction.cpp a18527b 

Diff: https://git.reviewboard.kde.org/r/119713/diff/

Testing
-------

KGeography menu items have icons again.

Thanks,

Albert Astals Cid

--===============3956961689454367106==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119713/">https://git.reviewboard.kde.org/r/119713/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Albert Astals Cid.</div>

<p style="color: grey;"><i>Updated ago. 11, 2014, 4:15 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kconfigwidgets
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I am running KGeography in a user which has oxygen \
icons available but since i'm not running neither the kde QPT nor oxygen style nor \
anything, while moving from KIcon to QIcon::fromTheme i lost most of my icons (since \
there is no kiconloader in the middle anymore), and the same for kstandardaction \
icons.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch makes it so that if you are using \
kstandardactions and your icon theme is hicolor but you have breeze or oxygen \
installed it changes the theme to one of those.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I am \
unconvinced if we want this here or if i want this in my (and potentially) every \
application so when we run in Gnome or Unity, our apps get icons what were getting in \
kde4 times because they were using KIcon and they would lose now because of the \
QIcon::fromTheme recommendation.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Obviously the missing \
icons also get fixed by QT_QPA_PLATFORMTHEME=kde but one can not expect to have this \
define when on non Plasma desktops and since in the past KIcon gave you oxygen-icons \
even if you were not on plasma i think it makes sense to do this.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KGeography menu items have icons again.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kstandardaction.cpp <span style="color: grey">(a18527b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119713/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3956961689454367106==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 