[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115502: Fix math function checks
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2014-02-05 19:41:50
Message-ID: 20140205194150.28358.7144 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 5, 2014, 7:37 p.m., Bernd Buschinski wrote:
> > Ship It!
and btw good catch for the math vs. cmake undef, seems like I overlooked it :)
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115502/#review49067
-----------------------------------------------------------
On Feb. 5, 2014, 5:03 p.m., Alex Merry wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115502/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 5:03 p.m.)
>
>
> Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.
>
>
> Repository: kjs
>
>
> Description
> -------
>
> Fix math function checks
>
> Between things being in the std:: namespace and <math.h> and <cmath>
> interfering with each other (at least for glibc), the configure checks
> for math functions do not actually perform the checks they claim to.
>
> This tests that the functions (in whatever form) can reasonably be
> called from C++ code that includes both <math.h> and <cmath>.
>
>
> Diffs
> -----
>
> src/kjs/ConfigureChecks.cmake 473da1c19c9e8788e3ac407d382f8bcf4882a10f
> src/kjs/global.h.cmake d821a7264f0e2b46b422a8d68d397799a288bde9
> src/kjs/operations.h a54f366330b937a027d478cbe018a7c1c21c1625
>
> Diff: https://git.reviewboard.kde.org/r/115502/diff/
>
>
> Testing
> -------
>
> Configures, builds and installs with gcc 4.8.2 and glibc 2.18 (Archlinux). The \
> configure checks report the results you would expect (providing you are aware that \
> cmath undefs signbit).
>
> Thanks,
>
> Alex Merry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115502/">https://git.reviewboard.kde.org/r/115502/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2014, 7:37 p.m. UTC, <b>Bernd \
Buschinski</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">and btw good catch for \
the math vs. cmake undef, seems like I overlooked it :)</pre> <br />
<p>- Bernd</p>
<br />
<p>On February 5th, 2014, 5:03 p.m. UTC, Alex Merry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks, Bernd Buschinski and Harald Fernengel.</div>
<div>By Alex Merry.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2014, 5:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fix math function checks
Between things being in the std:: namespace and <math.h> and <cmath>
interfering with each other (at least for glibc), the configure checks
for math functions do not actually perform the checks they claim to.
This tests that the functions (in whatever form) can reasonably be
called from C++ code that includes both <math.h> and <cmath>.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Configures, builds and installs with gcc 4.8.2 and glibc 2.18 \
(Archlinux). The configure checks report the results you would expect (providing you \
are aware that cmath undefs signbit).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kjs/ConfigureChecks.cmake <span style="color: \
grey">(473da1c19c9e8788e3ac407d382f8bcf4882a10f)</span></li>
<li>src/kjs/global.h.cmake <span style="color: \
grey">(d821a7264f0e2b46b422a8d68d397799a288bde9)</span></li>
<li>src/kjs/operations.h <span style="color: \
grey">(a54f366330b937a027d478cbe018a7c1c21c1625)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115502/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic