[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115494: Build on Mac OS X
From: "Bernd Buschinski" <b.buschinski () googlemail ! com>
Date: 2014-02-05 19:41:01
Message-ID: 20140205194101.20382.49711 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 5, 2014, 5:04 p.m., Alex Merry wrote:
> > Nope, still breaks on Linux. I think it's because <cmath> undefs the signbit \
> > macro.
> > I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for this \
> > part of your request.
I would also prefer https://git.reviewboard.kde.org/r/115494/ for the math checks.
But still your patch is not invalid, as it has the struct timerval wrt thingie, so as \
it looks safe, I would say, for the struct stuff, ship it
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115494/#review49051
-----------------------------------------------------------
On Feb. 5, 2014, 4:06 p.m., Harald Fernengel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115494/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2014, 4:06 p.m.)
>
>
> Review request for KDE Frameworks and Bernd Buschinski.
>
>
> Repository: kjs
>
>
> Description
> -------
>
> Build on Mac OS X
>
> Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so \
> manually cast to the required type.
> Also, there seems to be some magic with __signbit, it seems to be detected but then \
> compilation fails. Prefer the suggested ::signbit() instead if available.
>
> Diffs
> -----
>
> src/kjs/ConfigureChecks.cmake 473da1c
> src/kjs/global.h.cmake d821a72
> src/kjs/interpreter.cpp e699651
> src/kjs/operations.h a54f366
>
> Diff: https://git.reviewboard.kde.org/r/115494/diff/
>
>
> Testing
> -------
>
> It compiles again on Mac OS X :)
>
>
> Thanks,
>
> Harald Fernengel
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115494/">https://git.reviewboard.kde.org/r/115494/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 5th, 2014, 5:04 p.m. UTC, <b>Alex \
Merry</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Nope, still breaks on Linux. I think it's because <cmath> \
undefs the signbit macro.
I propose https://git.reviewboard.kde.org/r/115502/ as the proper fix for this part \
of your request.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would also prefer \
https://git.reviewboard.kde.org/r/115494/ for the math checks.
But still your patch is not invalid, as it has the struct timerval wrt thingie, so as \
it looks safe, I would say, for the struct stuff, ship it</pre> <br />
<p>- Bernd</p>
<br />
<p>On February 5th, 2014, 4:06 p.m. UTC, Harald Fernengel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks and Bernd Buschinski.</div>
<div>By Harald Fernengel.</div>
<p style="color: grey;"><i>Updated Feb. 5, 2014, 4:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kjs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build on Mac OS X
Seems that clang on OS X is a bit more strict on struct timerval wrt. longs, so \
manually cast to the required type.
Also, there seems to be some magic with __signbit, it seems to be detected but then \
compilation fails. Prefer the suggested ::signbit() instead if available.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles again on Mac OS X :)</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kjs/ConfigureChecks.cmake <span style="color: grey">(473da1c)</span></li>
<li>src/kjs/global.h.cmake <span style="color: grey">(d821a72)</span></li>
<li>src/kjs/interpreter.cpp <span style="color: grey">(e699651)</span></li>
<li>src/kjs/operations.h <span style="color: grey">(a54f366)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115494/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic