[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-edu-devel
Subject: Re: Review Request 122581: [klettres] Do not depend on kdelibs4support
From: "Christoph Feck" <cfeck () kde ! org>
Date: 2015-02-24 11:25:16
Message-ID: 20150224112516.12883.61608 () probe ! kde ! org
[Download RAW message or body]
--===============4178392733838867435==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Feb. 15, 2015, 11:54 p.m., Aleix Pol Gonzalez wrote:
> > src/CMakeLists.txt, line 25
> > <https://git.reviewboard.kde.org/r/122581/diff/1/?file=349848#file349848line25>
> >
> > Use ecm_add_app_icon in ECMAddAppIcon.cmake.
>
> Christoph Feck wrote:
> I just noticed that this is brand new in ECM 1.7.0. Can we already depend on it?
>
> Albert Astals Cid wrote:
> Well, it's using a released thing on an unreleased branch, i'd say sure.
ECMAddAppIcon needs different filenames for the PNG files compared to \
ECMInstallIcons...
- Christoph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122581/#review76090
-----------------------------------------------------------
On Feb. 15, 2015, 7:53 p.m., Christoph Feck wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122581/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2015, 7:53 p.m.)
>
>
> Review request for KDE Edu and Laurent Navet.
>
>
> Repository: klettres
>
>
> Description
> -------
>
> No idea if kde4_add_app_icon has a replacement in KF5. It seems to be commented \
> everywhere.
>
> Diffs
> -----
>
> CMakeLists.txt acf1071
> src/CMakeLists.txt 8e07c51
>
> Diff: https://git.reviewboard.kde.org/r/122581/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Christoph Feck
>
>
--===============4178392733838867435==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122581/">https://git.reviewboard.kde.org/r/122581/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 15th, 2015, 11:54 p.m. UTC, <b>Aleix \
Pol Gonzalez</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122581/diff/1/?file=349848#file349848line25" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">25</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">kde4_add_app_icon(klettres_SRCS</span> <span \
class="err">"${CMAKE_CURRENT_SOURCE_DIR}/hi*-apps-klettres.png")</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px \
solid #C0C0C0;" align="right"><font size="2">25</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="c"><span class="hl">#</span>kde4_add_app_icon(klettres_SRCS \
"${CMAKE_CURRENT_SOURCE_DIR}/hi*-apps-klettres.png")</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Use \
ecm_add_app_icon in ECMAddAppIcon.cmake.</p></pre> </blockquote>
<p>On February 17th, 2015, 11:06 a.m. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I just noticed that this \
is brand new in ECM 1.7.0. Can we already depend on it?</pre> </blockquote>
<p>On February 22nd, 2015, 1:48 p.m. UTC, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, \
it's using a released thing on an unreleased branch, i'd say sure.</p></pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ECMAddAppIcon needs different filenames for the PNG files compared to \
ECMInstallIcons...</pre> <br />
<p>- Christoph</p>
<br />
<p>On February 15th, 2015, 7:53 p.m. UTC, Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Edu and Laurent Navet.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated Feb. 15, 2015, 7:53 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
klettres
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No idea if kde4_add_app_icon has a replacement in KF5. It seems to be \
commented everywhere.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(acf1071)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(8e07c51)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122581/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4178392733838867435==--
[Attachment #3 (text/plain)]
_______________________________________________
kde-edu mailing list
kde-edu@mail.kde.org
https://mail.kde.org/mailman/listinfo/kde-edu
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic