[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] powerdevil-remove-cpufreq.patch
From:       Dario Freddi <drf54321 () gmail ! com>
Date:       2010-03-19 13:49:48
Message-ID: 201003191449.48862.drf54321 () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 19 March 2010 14:39:29 Holger Macht wrote:
> On Fri 19. Mar - 14:30:44, Dario Freddi wrote:
> > On Friday 19 March 2010 14:25:58 Sebastian Kügler wrote:
> > > On Friday 19 March 2010 14:18:34 Dario Freddi wrote:
> > > >   On Friday 19 March 2010 14:02:47 Sebastian Kügler wrote:
> > > > > I was assuming that you had an SVN account, and was waiting for
> > > > > Dario to have a look. If he likes it, I'm happy to commit. :)
> > > > 
> > > > P.S.: I actually like it. But I do also recognize that some people
> > > > might have  full control. Those people surely know how to edit text
> > > > files.
> > > 
> > > Isn't it a lot easier (and even doable in the UI) to specify this as
> > > "run this command when switched to profile")? IMO this is the exact
> > > reason why that option is there in the first place.
> > 
> > Possibly. However, this might require root privileges if done from a
> > terminal, isn't it? Otherwise yes, it can be completely ok.
> 
> No root privileges are required. At least not when using the HAL
> interface which Solid does.

Ok, then a good approach would be keeping the solid-powermanagement shell 
alive with that setting enabled and tell people who want to switch their 
profile to use a script.

> 
> > P.S.: Has there been any testing for this patch, BTW?
> 
> Of course I tested it myself, no idea about further tests.

Sebastian, if you have 2 minutes to test it out, could you please apply it to 
your local copy and test? If it works fine it's totally ok for me to go in, 
and you can commit it straight.

> 
> Regards,
>  Holger
> 
> >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to
> >> unsubscribe <<

-- 
-------------------

Dario Freddi
KDE Developer
GPG Key Signature: 511A9A3B

["signature.asc" (application/pgp-signature)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<


[prev in list] [next in list] [prev in thread] [next in thread]