From kde-devel Fri Mar 19 13:49:48 2010 From: Dario Freddi Date: Fri, 19 Mar 2010 13:49:48 +0000 To: kde-devel Subject: Re: [PATCH] powerdevil-remove-cpufreq.patch Message-Id: <201003191449.48862.drf54321 () gmail ! com> X-MARC-Message: https://marc.info/?l=kde-devel&m=126900681911224 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0816800973==" --===============0816800973== Content-Type: multipart/signed; boundary="nextPart1363651.m3f2NbKFae"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart1363651.m3f2NbKFae Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable On Friday 19 March 2010 14:39:29 Holger Macht wrote: > On Fri 19. Mar - 14:30:44, Dario Freddi wrote: > > On Friday 19 March 2010 14:25:58 Sebastian K=FCgler wrote: > > > On Friday 19 March 2010 14:18:34 Dario Freddi wrote: > > > > On Friday 19 March 2010 14:02:47 Sebastian K=FCgler wrote: > > > > > I was assuming that you had an SVN account, and was waiting for > > > > > Dario to have a look. If he likes it, I'm happy to commit. :) > > > >=20 > > > > P.S.: I actually like it. But I do also recognize that some people > > > > might have full control. Those people surely know how to edit text > > > > files. > > >=20 > > > Isn't it a lot easier (and even doable in the UI) to specify this as > > > "run this command when switched to profile")? IMO this is the exact > > > reason why that option is there in the first place. > >=20 > > Possibly. However, this might require root privileges if done from a > > terminal, isn't it? Otherwise yes, it can be completely ok. >=20 > No root privileges are required. At least not when using the HAL > interface which Solid does. Ok, then a good approach would be keeping the solid-powermanagement shell=20 alive with that setting enabled and tell people who want to switch their=20 profile to use a script. >=20 > > P.S.: Has there been any testing for this patch, BTW? >=20 > Of course I tested it myself, no idea about further tests. Sebastian, if you have 2 minutes to test it out, could you please apply it = to=20 your local copy and test? If it works fine it's totally ok for me to go in,= =20 and you can commit it straight. >=20 > Regards, > Holger >=20 > >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to > >> unsubscribe << =2D-=20 =2D------------------ Dario Freddi KDE Developer GPG Key Signature: 511A9A3B --nextPart1363651.m3f2NbKFae Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAkujgPwACgkQaqeZcVEamjuvXACfZKuc7Pdn7hsPf3vShBN26p5p CVkAn2D71vGLV0fjAmcvFLVpIw6c9RKb =Fman -----END PGP SIGNATURE----- --nextPart1363651.m3f2NbKFae-- --===============0816800973== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============0816800973==--