[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Bug in resizing icons on the desktop from kde control center
From:       David Faure <david () mandrakesoft ! com>
Date:       2002-02-27 15:18:28
[Download RAW message or body]

On Tuesday 26 February 2002 04:52, Holger Schröder wrote:
> i tried to figure out what the problem was, and i could not get a slot 
> in kdebase/kdesktop/desktop.cc connected to the iconChanged(int group) 
> signal.
> to my understanding of it, it _should_ work, but it doesn`t....

How so ? Do you mean the slot is never triggered ?
It's definitely triggered here:
8211 kdesktop: KDesktop::slotIconChanged reached
8211 kdesktop: KDesktop::slotIconChanged reached
8211 kdesktop: KDesktop::slotIconChanged reached
8211 kdesktop: KDesktop::slotIconChanged reached
8211 kdesktop: KDesktop::slotIconChanged reached
8211 kdesktop: KDesktop::slotIconChanged reached

Yup, 6 times. I got 6 message boxes ;)
Much more than necessary - maybe just to catchup with the times it 
didn't work for you ;)
Ah, the slot should test for group==KIcon::Desktop, it doesn't care about
the other type of icons. Oh, and the real bug was in kiconthemes.cpp, fixing.

> so i wrote a small program from scratch, which solves the problem, i 
> will attach it here.
> perhaps you could tell me, what the problem is with the code above, 
> then i could integrate it in a clean way.
> the prog listens to all iconChanged signals and "collects" them with a 
> timer, it only refreshes the desktop once when the timer timed out, a 
> timeout of 100 (0,1 s) works fine for me. the prog also has some 
> variables, which save the size of the icons and calls lineupIcons, when 
> the new iconsize is bigger than the old one, it also respects the 
> doubleSized pixels.
> The trash icon at size 16 pixels with double size looks broken somehow, 
> and sometimes there is a wrong iconsize of 32 in the config, even if i 
> change from 64 to 16 or vice versa.

Looks quite good (you did take some time about this ;)
You can remove the timer now that I fixed the kcontrol module.
I have also committed your patch, after adding the check for the group.

Thanks for integrating the above changes (calling lineUpIcons when necessary).

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://people.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]