[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Kandalf: request for review
From: Nicolas Fella <nicolas.fella () gmx ! de>
Date: 2023-12-08 0:06:53
Message-ID: e43afcfa-7041-447a-a587-5cb59ab86fa0 () gmx ! de
[Download RAW message or body]
On 12/8/23 00:49, Albert Astals Cid wrote:
> El divendres, 8 de desembre de 2023, a les 0:44:11 (CET), Carl Schwan va
> escriure:
>> On Fri, Dec 8, 2023, at 12:10 AM, Albert Astals Cid wrote:
>>> El dijous, 7 de desembre de 2023, a les 16:28:48 (CET), Loren Burkhold=
er
>>> va
>>>
>>> escriure:
>>>> Hi all!
>>>>
>>>> I've been working towards getting Kandalf ready for integration into =
KDE
>>>> (and I'd like to thank everyone who has pitched in to help me, mainly
>>>> Laurent and redstrate). At this point, while the app is not necessari=
ly
>>>> feature-complete or fully polished, it's getting close to that point.
>>>> Therefore, I'd like to officially request a review of Kandalf for
>>>> inclusion
>>>> in the KDE apps.
>>> Where is the thing we're supposed to review?
>> In the wrong place:https://invent.kde.org/lorendb/kandalf/-/issues/1
> And again we have people self-checking the checkboxes or their own revie=
w
> :sad_dance:
To be fair, nowhere in
https://community.kde.org/Policies/Application_Lifecycle#kdereview does
it say who is supposed to check what box, so people checking "obvious"
boxes like "It has a passing CI build" themselves isn't that far off.
>> I asked Loren to create a sysadmin ticket to get it moved to an offical
>> namespace.
>>
>> That seems premature? What if the review never succeeds?
[Attachment #3 (text/html)]
<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">On 12/8/23 00:49, Albert Astals Cid
wrote:<br>
</div>
<blockquote type="cite" cite="mid:2142250.uWDeo8xd7x@xps15">
<pre class="moz-quote-pre" wrap="">El divendres, 8 de desembre de 2023, a les \
0:44:11 (CET), Carl Schwan va escriure:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">On Fri, Dec 8, 2023, at 12:10 AM, Albert \
Astals Cid wrote: </pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">El dijous, 7 de desembre de 2023, a les \
16:28:48 (CET), Loren Burkholder va
escriure:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Hi all!
I've been working towards getting Kandalf ready for integration into KDE
(and I'd like to thank everyone who has pitched in to help me, mainly
Laurent and redstrate). At this point, while the app is not necessarily
feature-complete or fully polished, it's getting close to that point.
Therefore, I'd like to officially request a review of Kandalf for
inclusion
in the KDE apps.
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Where is the thing we're supposed to review?
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
In the wrong place: <a class="moz-txt-link-freetext" \
href="https://invent.kde.org/lorendb/kandalf/-/issues/1">https://invent.kde.org/lorendb/kandalf/-/issues/1</a>
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
And again we have people self-checking the checkboxes or their own review
> sad_dance:
</pre>
</blockquote>
To be fair, nowhere in
<a class="moz-txt-link-freetext" \
href="https://community.kde.org/Policies/Application_Lifecycle#kdereview">https://community.kde.org/Policies/Application_Lifecycle#kdereview</a>
does it say who is supposed to check what box, so people checking
"obvious" boxes like "It has a passing CI build" themselves isn't
that far off.<span style="white-space: pre-wrap">
</span>
<blockquote type="cite" cite="mid:2142250.uWDeo8xd7x@xps15">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">I asked Loren to create a sysadmin ticket \
to get it moved to an offical namespace.
That seems premature? What if the review never succeeds?
</pre>
</blockquote>
</blockquote>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic