[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Enable kdialog to set an icon for passivepopup as
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2011-05-10 9:58:00
Message-ID: 20110510095800.19957.3858 () vidsolbach ! de
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/
-----------------------------------------------------------
(Updated May 10, 2011, 9:58 a.m.)
Review request for KDE Base Apps.
Changes
-------
Now uses KDE --icon option for passivepopup icon, so there are also no stri=
ng changes (removed --passiveicon explanation from Commandline args)
Changed parameter duration (back) to timeout.
Summary
-------
Since I use kdialog a lot, I wanted it to be able to set an icon for passiv=
e Plasma notifications as well.
I saw that the icon was hardcoded to dialog-information and tried to enable=
it to parse the --icon command line argument and pass it to the dbus call =
that triggers the notification.
I could not test the patch however, since I do not (yet) have a full develo=
pment environment or its dependencies, and I do not even know if this is th=
e right approach, but I hope you can have a look at it.
Diffs (updated)
-----
kdialog/kdialog.cpp b80ad9a =
Diff: http://git.reviewboard.kde.org/r/101282/diff
Testing
-------
Thanks,
Kai Uwe
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101282/">http://git.reviewboard.kde.org/r/101282/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 10, 2011, 9:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Now uses KDE --icon option for passivepopup icon, so there are also no \
string changes (removed --passiveicon explanation from Commandline args) Changed \
parameter duration (back) to timeout.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since I use kdialog a lot, I wanted it to be able to set an icon for \
passive Plasma notifications as well. I saw that the icon was hardcoded to \
dialog-information and tried to enable it to parse the --icon command line argument \
and pass it to the dbus call that triggers the notification. I could not test the \
patch however, since I do not (yet) have a full development environment or its \
dependencies, and I do not even know if this is the right approach, but I hope you \
can have a look at it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>kdialog/kdialog.cpp <span style="color: grey">(b80ad9a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101282/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic