[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-core-devel
Subject: Re: Review Request: Enable kdialog to set an icon for passivepopup as
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2011-05-10 9:36:50
Message-ID: 20110510093650.19193.37935 () vidsolbach ! de
[Download RAW message or body]
> On May 9, 2011, 7:37 p.m., David Palacio wrote:
> > kdialog/kdialog.cpp, line 366
> > <http://git.reviewboard.kde.org/r/101282/diff/1/?file=15998#file15998line366>
> >
> > --icon is a KDE option.
> > Maybe that's why the first diff did not work?
I'll try again using --icon KDE option
> On May 9, 2011, 7:37 p.m., David Palacio wrote:
> > kdialog/kdialog.cpp, line 101
> > <http://git.reviewboard.kde.org/r/101282/diff/5/?file=16253#file16253line101>
> >
> > s/duration/timeout
> > There's no need to change this name here and you change it backwards some lines \
> > below. KDialog's usage text names this option "timeout" as well.
That was some experiment and I forgot to completely revert it. Will change it ;)
- Kai Uwe
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101282/#review3228
-----------------------------------------------------------
On May 6, 2011, 2:52 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101282/
> -----------------------------------------------------------
>
> (Updated May 6, 2011, 2:52 p.m.)
>
>
> Review request for KDE Base Apps.
>
>
> Summary
> -------
>
> Since I use kdialog a lot, I wanted it to be able to set an icon for passive Plasma \
> notifications as well. I saw that the icon was hardcoded to dialog-information and \
> tried to enable it to parse the --icon command line argument and pass it to the \
> dbus call that triggers the notification. I could not test the patch however, since \
> I do not (yet) have a full development environment or its dependencies, and I do \
> not even know if this is the right approach, but I hope you can have a look at it.
>
> Diffs
> -----
>
> kdialog/kdialog.cpp b80ad9a
>
> Diff: http://git.reviewboard.kde.org/r/101282/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kai Uwe
>
>
[Attachment #3 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101282/">http://git.reviewboard.kde.org/r/101282/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 9th, 2011, 7:37 p.m., <b>David Palacio</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101282/diff/1/?file=15998#file15998line366" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdialog/kdialog.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static \
int directCommand(KCmdLineArgs *args)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">366</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KCmdLineArgs</span> <span class="o">*</span><span class="n">qtargs</span> \
<span class="o">=</span> <span class="n">KCmdLineArgs</span><span \
class="o">::</span><span class="n">parsedArgs</span><span class="p">(</span><span \
class="s">"qt"</span><span class="p">);</span> <span class="c1">// --icon \
is a qt option</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">--icon is a KDE option. \
Maybe that's why the first diff did not work?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll try \
again using --icon KDE option</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On May 9th, 2011, 7:37 p.m., <b>David Palacio</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/101282/diff/5/?file=16253#file16253line101" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kdialog/kdialog.cpp</a> <span style="font-weight: normal;">
(Diff revision 5)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
sendVisualNotification(QString text, QString title, int timeout)</pre></td> <td \
colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">99</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> \
<span class="n">sendVisualNotification</span><span class="p">(</span><span \
class="n">QString</span> <span class="n">text</span><span class="p">,</span> <span \
class="n">QString</span> <span class="n">title</span><span class="p">,</span> <span \
class="kt">int</span> <span class="n"><span class="hl">timeout</span></span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">101</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="kt">bool</span> <span \
class="n">sendVisualNotification</span><span class="p">(</span><span \
class="n">QString</span> <span class="n">text</span><span class="p">,</span> <span \
class="k"><span class="hl">const</span></span><span class="hl"> </span><span \
class="n">QString</span> <span class="o"><span class="hl">&</span></span><span \
class="n">title</span><span class="p">,</span> <span class="k"><span \
class="hl">const</span></span><span class="hl"> </span><span class="n"><span \
class="hl">QString</span></span><span class="hl"> </span><span class="o"><span \
class="hl">&</span></span><span class="n"><span \
class="hl">icon</span></span><span class="p"><span class="hl">,</span></span><span \
class="hl"> </span><span class="kt">int</span> <span class="n"><span \
class="hl">duration</span></span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">s/duration/timeout \
There's no need to change this name here and you change it backwards some lines \
below. KDialog's usage text names this option "timeout" as well.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That was \
some experiment and I forgot to completely revert it. Will change it ;)</pre> <br />
<p>- Kai Uwe</p>
<br />
<p>On May 6th, 2011, 2:52 p.m., Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 6, 2011, 2:52 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Since I use kdialog a lot, I wanted it to be able to set an icon for \
passive Plasma notifications as well. I saw that the icon was hardcoded to \
dialog-information and tried to enable it to parse the --icon command line argument \
and pass it to the dbus call that triggers the notification. I could not test the \
patch however, since I do not (yet) have a full development environment or its \
dependencies, and I do not even know if this is the right approach, but I hope you \
can have a look at it.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdialog/kdialog.cpp <span style="color: grey">(b80ad9a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101282/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic