[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-core-devel
Subject:    [patch] declared but non-implemented methods (remove, implement?)
From:       Germain Garand <germain () ebooksfrance ! com>
Date:       2003-09-20 21:49:11
[Download RAW message or body]

Hello,

While building the new Smokekde wrapper library, kalyptus has spotted several
non-implemented methods.

I have gathered those in the attached patch:
1) non-implemented-since-3.1.diff => those are present in the 3.1 API as well 
as in current CVS
2) non-implemented-in-head.diff => only in CVS, so probably awaiting for 
implementation but who knows 8)
3) ktabwidget.h => has 3 inline methods whose implementation isn't in the 
header file, hence would cause linker errors

Otherwise, whenever methods are intentionally left unimplemented (e.g copy 
constructor in KInstance and KSSLSession) it would be handy for us bindings 
folks to have a marker (e.g KDE_NOT_IMPLEMENTED). Would it be possible?

HIH,
Germain
["ktabwidget.h.diff" (text/x-diff)]

Index: kdeui/ktabwidget.h
===================================================================
RCS file: /home/kde/kdelibs/kdeui/ktabwidget.h,v
retrieving revision 1.23
diff -u -3 -b -B -p -r1.23 ktabwidget.h
--- kdeui/ktabwidget.h	2 Sep 2003 21:07:51 -0000	1.23
+++ kdeui/ktabwidget.h	20 Sep 2003 20:55:56 -0000
@@ -54,7 +54,7 @@ public:
       you from which index to which index a tab has been moved.
     */
     void setTabReorderingEnabled( bool enable );
-    inline bool isTabReorderingEnabled() const;
+    bool isTabReorderingEnabled() const;

     /*!
       If \a enable is true, a close button will be shown on mouse hover
@@ -62,14 +62,14 @@ public:
       when pressed.
     */
     void setHoverCloseButton( bool enable );
-    inline bool hoverCloseButton() const;
+    bool hoverCloseButton() const;

     /*!
       If \a delayed is true, a close button will be shown on mouse hover
       over tab icons immediately else after double mouse double click delay.
     */
     void setHoverCloseButtonDelayed( bool delayed );
-    inline bool hoverCloseButtonDelayed() const;
+    bool hoverCloseButtonDelayed() const;

 public slots:
     /*!

["non-implemented-in-head.diff" (text/x-diff)]

Index: kio/bookmarks/kbookmarkmenu.h
===================================================================
RCS file: /home/kde/kdelibs/kio/bookmarks/kbookmarkmenu.h,v
retrieving revision 1.67
diff -u -3 -b -B -p -r1.67 kbookmarkmenu.h
--- kio/bookmarks/kbookmarkmenu.h	11 Sep 2003 22:53:35 -0000	1.67
+++ kio/bookmarks/kbookmarkmenu.h	20 Sep 2003 20:55:58 -0000
@@ -188,7 +188,6 @@ protected:
   void addNewFolder();

   void fillContextMenu( QPopupMenu *, const QString &, int );
-  bool invalid( int val );

   bool m_bIsRoot:1;
   bool m_bAddBookmark:1;



Index: kio/kio/ktar.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kio/ktar.h,v
retrieving revision 1.33
diff -u -3 -b -B -p -r1.33 ktar.h
--- kio/kio/ktar.h	16 Aug 2003 19:45:10 -0000	1.33
+++ kio/kio/ktar.h	20 Sep 2003 20:56:00 -0000
@@ -145,10 +145,6 @@ protected:
     bool prepareWriting_impl(const QString& name, const QString& user,
     			const QString& group, uint size, mode_t perm,
     			time_t atime, time_t mtime, time_t ctime);
-    bool writeFile_impl(const QString& name, const QString& user,
-    			const QString& group, uint size, mode_t perm,
-    			time_t atime, time_t mtime, time_t ctime,
-       			const char* data);
     bool writeDir_impl(const QString& name, const QString& user,
     			const QString& group, mode_t perm,
     			time_t atime, time_t mtime, time_t ctime );


Index: kio/kssl/ksslpkcs7.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kssl/ksslpkcs7.h,v
retrieving revision 1.5
diff -u -3 -b -B -p -r1.5 ksslpkcs7.h
--- kio/kssl/ksslpkcs7.h	16 Aug 2003 16:38:56 -0000	1.5
+++ kio/kssl/ksslpkcs7.h	20 Sep 2003 20:56:00 -0000
@@ -124,29 +124,12 @@ public:
 	KSSLCertificate::KSSLValidation validate();

 	/**
-	 *  Check the chain to make sure it's valid for a specified purpose.
-	 *  @param p the purpose to validate for
-	 *  @return the result of the validation procedure
-	 *  @see KSSLCertificate
-	 */
-	KSSLCertificate::KSSLValidation validate(KSSLCertificate::KSSLPurpose p);
-
-	/**
 	 *  Check the chain to make sure it's valid.
 	 *  Ignore any cached validation result.
 	 *  @return the result of the validation
 	 *  @see KSSLCertificate
 	 */
 	KSSLCertificate::KSSLValidation revalidate();
-
-	/**
-	 *  Check the chain to make sure it's valid for a specific purpose.
-	 *  Ignore any cached validation result.
-	 *  @param p the purpose to validate for
-	 *  @return the result of the validation
-	 *  @see KSSLCertificate
-	 */
-	KSSLCertificate::KSSLValidation revalidate(KSSLCertificate::KSSLPurpose p);

 	/**
 	 *  Return true if the chain is valid.

["non-implemented-since-3.1.diff" (text/x-diff)]

Index: kdecore/kaccel.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kaccel.h,v
retrieving revision 1.96
diff -u -3 -b -B -p -r1.96 kaccel.h
--- kdecore/kaccel.h	30 Aug 2003 07:33:48 -0000	1.96
+++ kdecore/kaccel.h	20 Sep 2003 20:55:54 -0000
@@ -141,13 +141,6 @@ class KAccel : public QAccel
 	void setEnabled( bool bEnabled );

 	/**
-	 * Checks whether auto-update of connections is enabled.
-	 * @return true if auto-update is enabled (the default)
-	 * @see setAutoUpdate()
-	 */
-	bool getAutoUpdate();
-
-	/**
 	 * Enable auto-update of connections. This means that the signals
 	 * are automatically disconnected when you disable an action, and
 	 * re-enabled when you enable it. By default auto update is turned
@@ -217,14 +210,6 @@ class KAccel : public QAccel
 	KAccelAction* insert( KStdAccel::StdAccel id,
 	                 const QObject* pObjSlot, const char* psMethodSlot,
 	                 bool bConfigurable = true, bool bEnabled = true );
-	/**
-	 * Use this to insert a label into the action list.  This will be
-	 * displayed when the user configures shortcuts.
-	 * @param sName the name of the action
-	 * @param sLabel the label of the action
-	 * @return the created KAccelAction
-	 */
-	KAccelAction* insert( const QString& sName, const QString& sLabel );

         /**
          * Removes the accelerator action identified by the name.


Index: kdeui/kanimwidget.h
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kanimwidget.h,v
retrieving revision 1.14
diff -u -3 -b -B -p -r1.14 kanimwidget.h
--- kdeui/kanimwidget.h 16 Aug 2003 19:45:01 -0000      1.14
+++ kdeui/kanimwidget.h 20 Sep 2003 21:18:28 -0000
@@ -75,15 +75,6 @@ public:
                QWidget *parent = 0L, const char *name = 0L );

   /**
-   * Default constructor.  This will not do anything until you use
-   * setIcons() later.
-   *
-   * @param parent The standard parent
-   * @param name   The standard internal name
-   */
-  KAnimWidget( QWidget *parent = 0L, const char *name = 0L );
-
-  /**
    * Destructor
    */
   virtual ~KAnimWidget();


Index: kdecore/kcharsets.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kcharsets.h,v
retrieving revision 1.55
diff -u -3 -b -B -p -r1.55 kcharsets.h
--- kdecore/kcharsets.h	16 Aug 2003 19:44:57 -0000	1.55
+++ kdecore/kcharsets.h	20 Sep 2003 20:55:54 -0000
@@ -123,19 +123,6 @@ public:
     QStringList descriptiveEncodingNames();

     /**
-     * Lists all languages.
-     * @return a list of all languages
-     */
-    QStringList languages();
-
-    /**
-     * Lists all available encodings for language name 'language'.
-     * @param language to language to search for
-     * @return the list of encodings for the language
-     */
-    QStringList encodingsForLanguage( const QString &language );
-
-    /**
      * Returns the language the encoding is used for.
      * @param encoding the encoding for the language
      * @return the language of the encoding


Index: kdecore/kglobalaccel.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kglobalaccel.h,v
retrieving revision 1.58
diff -u -3 -b -B -p -r1.58 kglobalaccel.h
--- kdecore/kglobalaccel.h	16 Aug 2003 19:44:57 -0000	1.58
+++ kdecore/kglobalaccel.h	20 Sep 2003 20:55:54 -0000
@@ -139,13 +139,6 @@ class KGlobalAccel : public QObject
 	 * @return true if successful, false otherwise
 	 */
 	bool setSlot( const QString& sAction, const QObject* pObjSlot, const char* psMethodSlot );
-	/**
-	 * Enable or disable the action named by @p sAction.
-	 * @param sAction the name of the action
-	 * @param bEnabled true to enable, false to disable
-	 * @return true if successful, false otherwise
-	 */
-	bool setEnabled( const QString& sAction, bool bEnabled );

 	/**
 	 * Returns the configuration group that is used to save the accelerators.


Index: kdecore/kinstance.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kinstance.h,v
retrieving revision 1.27
diff -u -3 -b -B -p -r1.27 kinstance.h
--- kdecore/kinstance.h	16 Aug 2003 19:44:57 -0000	1.27
+++ kdecore/kinstance.h	20 Sep 2003 20:55:54 -0000
@@ -98,8 +98,6 @@ class KInstance
      */
     void newIconLoader() const;

-    KCharsets	     *charsets() const;
-
     /**
      *  Returns the about data of this instance
      *  Warning, can be 0L


Index: kdecore/kshortcut.h
===================================================================
RCS file: /home/kde/kdelibs/kdecore/kshortcut.h,v
retrieving revision 1.23
diff -u -3 -b -B -p -r1.23 kshortcut.h
--- kdecore/kshortcut.h	20 Aug 2003 08:01:42 -0000	1.23
+++ kdecore/kshortcut.h	20 Sep 2003 20:55:55 -0000
@@ -174,16 +174,6 @@ class KKey
 	/**
 	 * @internal
 	 */
-	bool isValidQt() const;
-
-	/**
-	 * @internal
-	 */
-	bool isValidNative() const;
-
-	/**
-	 * @internal
-	 */
 	uint sym() const;
 	/**
 	 * @internal
@@ -424,11 +414,6 @@ class KKeySequence
 	 * @return true if successful, false otherwise
 	 */
 	bool setKey( uint i, const KKey& key );
-
-	/**
-	 * @internal
-	 */
-	void setTriggerOnRelease( bool );

 	/**
 	 * Returns true if the key sequence is null (after clear() or empty



Index: kio/kfile/kcombiview.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kfile/kcombiview.h,v
retrieving revision 1.28
diff -u -3 -b -B -p -r1.28 kcombiview.h
--- kio/kfile/kcombiview.h	30 Aug 2003 17:37:51 -0000	1.28
+++ kio/kfile/kcombiview.h	20 Sep 2003 20:55:58 -0000
@@ -102,9 +102,6 @@ public:
 
     virtual void setAcceptDrops(bool b);
 
-    // KDE 4: Make virtual
-    void setDropOptions(int options);
-
 protected:
     KFileIconView *left;
     KFileView *right;


Index: kio/kfile/kfiledialog.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kfile/kfiledialog.h,v
retrieving revision 1.147
diff -u -3 -b -B -p -r1.147 kfiledialog.h
--- kio/kfile/kfiledialog.h	17 Sep 2003 06:53:20 -0000	1.147
+++ kio/kfile/kfiledialog.h	20 Sep 2003 20:55:58 -0000
@@ -791,12 +791,6 @@ protected:
     KFileFilterCombo *filterWidget;

     /**
-     * adds a entry of the current directory. If disableUpdating is set
-     * to true, it will care about clever updating
-     **/
-    void addDirEntry(KFileItem *entry, bool disableUpdating);
-
-    /**
      * Reimplemented to animate the cancel button.
      */
     virtual void keyPressEvent( QKeyEvent *e );


Index: kio/kio/kemailsettings.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kio/kemailsettings.h,v
retrieving revision 1.7
diff -u -3 -b -B -p -r1.7 kemailsettings.h
--- kio/kio/kemailsettings.h	27 Nov 2002 20:53:32 -0000	1.7
+++ kio/kio/kemailsettings.h	20 Sep 2003 20:55:59 -0000
@@ -139,28 +139,6 @@ public:
 	  **/
 	void setSetting(KEMailSettings::Setting s, const QString &v);

-	/**
-	 * Get a extended setting.
-	 * Use this when trying to get at currently unimplemented settings
-	 * such as POP3 authentication methods, or mail specific TLS settings
-	 * or something I haven't already thought of.
-	 * @param e the extensions of the setting
-	 * @param s the key name
-	 * @return the value of the setting
-	 **/
-	QString getExtendedSetting(KEMailSettings::Extension e, const QString &s );
-
-	/**
-	 * Set a extended setting.
-	 * Use this when trying to get at currently unimplemented settings
-	 * such as POP3 authentication methods, or mail specific TLS settings
-	 * or something I haven't already thought of.
-	 * @param e the extended setting
-	 * @param s the key name
-	 * @param v the value of the setting
-	 **/
-	void setExtendedSetting(KEMailSettings::Extension e, const QString &s, const QString &v );
-
 private:
 	KEMailSettingsPrivate *p;
 };


Index: kio/kio/kfilefilter.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kio/kfilefilter.h,v
retrieving revision 1.11
diff -u -3 -b -B -p -r1.11 kfilefilter.h
--- kio/kio/kfilefilter.h	16 Aug 2003 19:45:09 -0000	1.11
+++ kio/kio/kfilefilter.h	20 Sep 2003 20:55:59 -0000
@@ -115,12 +115,6 @@ public:
     virtual void setNameFilters( const QString& nameFilters );

     /**
-     * @internal
-     * not implemented?
-     */
-    QString nameFilters() const;
-
-    /**
      * Sets a list of mime filters. A file can only pass if its
      * mime type is contained in this list.
      * @param mimeFilters the list of mime types


Index: kio/kio/kfilemetainfo.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kio/kfilemetainfo.h,v
retrieving revision 1.57
diff -u -3 -b -B -p -r1.57 kfilemetainfo.h
--- kio/kio/kfilemetainfo.h	20 Aug 2003 08:01:43 -0000	1.57
+++ kio/kio/kfilemetainfo.h	20 Sep 2003 20:55:59 -0000
@@ -620,12 +620,6 @@ public:
     uint hint() const;

     /**
-     * Returns the unit for this item. See KFileMimeTypeInfo::Unit.
-     * @return the unit
-     **/
-    uint unit() const;
-
-    /**
      * Returns the atttributes for this item. See
      * KFileMimeTypeInfo::Attributes.
      * @return the attributes


Index: kio/kio/kprotocolmanager.h
===================================================================
RCS file: /home/kde/kdelibs/kio/kio/kprotocolmanager.h,v
retrieving revision 1.72
diff -u -3 -b -B -p -r1.72 kprotocolmanager.h
--- kio/kio/kprotocolmanager.h	20 Aug 2003 08:01:43 -0000	1.72
+++ kio/kio/kprotocolmanager.h	20 Sep 2003 20:56:00 -0000
@@ -128,14 +128,6 @@ public:
    */
   static int responseTimeout();

-  /**
-   * Returns the set default timeout value for connecting
-   * to remote machines.
-   *
-   * @return timeout value in seconds
-   */
-  static int defaultConnectTimeout();
-

 /*=============================== PROXY CONFIG ==============================*/


Index: kutils/kfind.h
===================================================================
RCS file: /home/kde/kdelibs/kutils/kfind.h,v
retrieving revision 1.19
diff -u -3 -b -B -p -r1.19 kfind.h
--- kutils/kfind.h	6 Sep 2003 19:06:38 -0000	1.19
+++ kutils/kfind.h	20 Sep 2003 20:56:01 -0000
@@ -284,10 +284,6 @@ signals:
     void dialogClosed();

 protected:
-    /**
-     * @internal Constructor for KReplace
-     */
-    KFind(const QString &pattern, const QString &replacement, long options, QWidget *parent);

     QWidget* parentWidget() const { return (QWidget *)parent(); }



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic