[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevplatform
From:       David Nolden <zwabel () googlemail ! com>
Date:       2009-11-26 8:45:00
Message-ID: 200911260945.01016.zwabel () googlemail ! com
[Download RAW message or body]

Am Donnerstag 26 November 2009 00:27:44 schrieb Andreas Pakulat:
> As far as I can see (while removing the support) its optional and simply
> did a re-format of the source. Not to mention that not all places used
> this according to my personal testing (I'm thinking of
> definitions-completion and signal/slot completion)

It is used whenever larger code-pieces are inserted, for example in exactly 
the cases you mentioned, or in the class-wizard. Without it, the user will 
always have to manually re-format inserted code, which makes the source-code 
insertion a lot less valuable.

https://bugs.kde.org/show_bug.cgi?id=183606

> > What is the exact troubles this code is causing,
> > except that it's not pretty? It hasn't ever crashed here..
> 
> Disable both formatters and try to configure it. And thats just the
> beginning. As I said it keeps around pointers of things it shouldn't,
> which can make it crash easily when plugins are loaded/unloaded (think
> about the sessions).
> 
> Additionally part of this was public API that exposed far too much
> internals. Even if we don't guarantee BC we don't have to clutter our
> API from the start either. And its not like this was used in a lot of
> places (I wouldn't have disabled the code in that case) already, so it
> was mostly a manual thing to do. And running astyle from a commandline
> isn't that hard ;)

Yes but this did allow partial code-snippets to be reformatted in context, 
which is a lot different from running astyle in the command-line.

If there is those problems, then we could also just cut out the thing down a 
bit by disallowing to change the source-formatter:
- Remove all source-formatters expect of astyle, forbid disabling source-
formatters

Or we could create and enable one source-formatter that calls a command-line 
tool that it reads from somewhere in the source-tree, using a 
".kdev_formatting" file, and then simply disable the complete GUI.

The problem is, that we really _need_ source formatting, as without a source-
formatter, the C++ support will create completely messy code in some places.

Greetings, David
[prev in list] [next in list] [prev in thread] [next in thread]