[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-commits
Subject:    Re: KDE/kdevplatform
From:       Andreas Pakulat <apaku () gmx ! de>
Date:       2009-11-25 23:27:44
Message-ID: 20091125232744.GE6508 () trinity ! apaku ! dnsalias ! org
[Download RAW message or body]

On 25.11.09 22:55:53, David Nolden wrote:
> Am Mittwoch 25 November 2009 21:34:56 schrieb Andreas Pakulat:
> > SVN commit 1054291 by apaku:
> > 
> > Disable the sourceformatter as its not possible to fix this up without
> > major time investment.
> > 
> > I've looked a bit at the code today and all I can say is wow,
> > this is broken. It stores pointers to plugins, doesn't update them as
> >  needed assumes everywhere that things will be alright (i.e. no
> >  empty-checks, no null-pointer-checks). This is not possible to fix easily
> >  without changing major parts of the code. At this point in the release
> >  such a major restructuring is not going to happen, additionally this
> >  codebase is basically unmaintained ever since it was imported into svn.
> 
> Source formatting is a pretty important part for source-code generation 
> (creating definitions, etc.).

As far as I can see (while removing the support) its optional and simply
did a re-format of the source. Not to mention that not all places used
this according to my personal testing (I'm thinking of
definitions-completion and signal/slot completion)

> What is the exact troubles this code is causing, 
> except that it's not pretty? It hasn't ever crashed here..

Disable both formatters and try to configure it. And thats just the
beginning. As I said it keeps around pointers of things it shouldn't,
which can make it crash easily when plugins are loaded/unloaded (think
about the sessions).

Additionally part of this was public API that exposed far too much
internals. Even if we don't guarantee BC we don't have to clutter our
API from the start either. And its not like this was used in a lot of
places (I wouldn't have disabled the code in that case) already, so it
was mostly a manual thing to do. And running astyle from a commandline
isn't that hard ;)

Andreas

-- 
A few hours grace before the madness begins again.
[prev in list] [next in list] [prev in thread] [next in thread]