[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cairo
Subject:    Re: [cairo] OpenType font variations and cairo
From:       Matthias Clasen <matthias.clasen () gmail ! com>
Date:       2017-09-28 23:14:13
Message-ID: CAFwd_vCJZp-ZRjWbng3RmbR6PbPuA3UNV-eS4eBxDufzjymDpw () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Sep 28, 2017 at 7:03 PM, Behdad Esfahbod <behdad.esfahbod@gmail.com>
wrote:

> +Khaled,Werner
>
> Two things:
>
>   * Werner, please please please remove code that change
> face->face_index.  It's bad bad bad.
>
>   * With Matthias's branch, we break Khaled's code, ie. if user creates
> FT_Face, sets variations on it, and creates cairo_face_t from, we reset /
> ignore those variations.  The fix would require savings the variations that
> were on the face when face was created, and use those instead of
> instance-defaults in apply_variations().  Matthias, any chance you can do
> this?
>

I'll have a look.

[Attachment #5 (text/html)]

<div dir="ltr">On Thu, Sep 28, 2017 at 7:03 PM, Behdad Esfahbod <span \
dir="ltr">&lt;<a href="mailto:behdad.esfahbod@gmail.com" \
target="_blank">behdad.esfahbod@gmail.com</a>&gt;</span> wrote:<br><div \
class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div \
dir="ltr"><div><div><div><div>+Khaled,Werner<br><br></div>Two things:<br><br></div>   \
* Werner, please please please remove code that change face-&gt;face_index.   \
It&#39;s bad bad bad.<br><br></div>   * With Matthias&#39;s branch, we break \
Khaled&#39;s code, ie. if user creates FT_Face, sets variations on it, and creates \
cairo_face_t from, we reset / ignore those variations.   The fix would require \
savings the variations that were on the face when face was created, and use those \
instead of instance-defaults in apply_variations().   Matthias, any chance you can do \
this?<br></div></div></blockquote><div><br></div><div>I&#39;ll have a look. \
<br></div></div><br></div></div>


[Attachment #6 (text/plain)]

-- 
cairo mailing list
cairo@cairographics.org
https://lists.cairographics.org/mailman/listinfo/cairo

[prev in list] [next in list] [prev in thread] [next in thread]