From cairo  Thu Sep 28 23:14:13 2017
From: Matthias Clasen <matthias.clasen () gmail ! com>
Date: Thu, 28 Sep 2017 23:14:13 +0000
To: cairo
Subject: Re: [cairo] OpenType font variations and cairo
Message-Id: <CAFwd_vCJZp-ZRjWbng3RmbR6PbPuA3UNV-eS4eBxDufzjymDpw () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=cairo&m=150664046025650
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1174805081=="

--===============1174805081==
Content-Type: multipart/alternative; boundary="94eb2c0bba4a1b2d5d055a4811cd"

--94eb2c0bba4a1b2d5d055a4811cd
Content-Type: text/plain; charset="UTF-8"

On Thu, Sep 28, 2017 at 7:03 PM, Behdad Esfahbod <behdad.esfahbod@gmail.com>
wrote:

> +Khaled,Werner
>
> Two things:
>
>   * Werner, please please please remove code that change
> face->face_index.  It's bad bad bad.
>
>   * With Matthias's branch, we break Khaled's code, ie. if user creates
> FT_Face, sets variations on it, and creates cairo_face_t from, we reset /
> ignore those variations.  The fix would require savings the variations that
> were on the face when face was created, and use those instead of
> instance-defaults in apply_variations().  Matthias, any chance you can do
> this?
>

I'll have a look.

--94eb2c0bba4a1b2d5d055a4811cd
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">On Thu, Sep 28, 2017 at 7:03 PM, Behdad Esfahbod <span dir=
=3D"ltr">&lt;<a href=3D"mailto:behdad.esfahbod@gmail.com" target=3D"_blank"=
>behdad.esfahbod@gmail.com</a>&gt;</span> wrote:<br><div class=3D"gmail_ext=
ra"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"m=
argin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir=3D"l=
tr"><div><div><div><div>+Khaled,Werner<br><br></div>Two things:<br><br></di=
v>=C2=A0 * Werner, please please please remove code that change face-&gt;fa=
ce_index.=C2=A0 It&#39;s bad bad bad.<br><br></div>=C2=A0 * With Matthias&#=
39;s branch, we break Khaled&#39;s code, ie. if user creates FT_Face, sets =
variations on it, and creates cairo_face_t from, we reset / ignore those va=
riations.=C2=A0 The fix would require savings the variations that were on t=
he face when face was created, and use those instead of instance-defaults i=
n apply_variations().=C2=A0 Matthias, any chance you can do this?<br></div>=
</div></blockquote><div><br></div><div>I&#39;ll have a look. <br></div></di=
v><br></div></div>

--94eb2c0bba4a1b2d5d055a4811cd--

--===============1174805081==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

LS0gCmNhaXJvIG1haWxpbmcgbGlzdApjYWlyb0BjYWlyb2dyYXBoaWNzLm9yZwpodHRwczovL2xp
c3RzLmNhaXJvZ3JhcGhpY3Mub3JnL21haWxtYW4vbGlzdGluZm8vY2Fpcm8=

--===============1174805081==--