[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 53885] khtml should NOT use "standard background" and "standard
From:       Laurie Bradshaw <lauriebradshaw () dsl ! pipex ! com>
Date:       2007-04-29 20:39:46
Message-ID: 20070429203946.7063.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=53885         




------- Additional Comments From lauriebradshaw dsl pipex com  2007-04-29 22:39 \
------- Still present in 3.5.6....

I've read quite a few postings about this bug, and appreciate that using the system \
background colour is correct. However this doesn't fit the use-case scenario of:

a. good web designers specify a background colour using css (no problem either way).
b. bad web designers assume the default background colour to be white.

User css is currently not an option due to the unique handling of the body element \
(margins are also coloured in the body colour, unlike any other element), and the \
rampant use of the deprecated bgcolor body attribute, which does not override user \
css.

Applying a colour to the html element using user css results in white borders round \
the body element (which can occasionally occupy a large portion of the page), and \
applying a colour to the body element using user css results in breakage of sites \
that are still using the bgcolor attribute.

My suggestion to solve this issue is to make sure the special handling of the body \
element happen whether the html element has a css specified background or not, making \
user css a viable solution for those wishing to use a 'non-standard' system colour \
scheme yet have black on white (or any other colours for that matter) as default \
colours for web pages.

In the meantime, for those who just want a fixed white background now:

--- khtml/rendering/render_box.cpp~	2007-04-29 21:37:09.000000000 +0100
+++ khtml/rendering/render_box.cpp	2007-04-29 21:37:11.000000000 +0100
 @ -323,7 +323,7  @
     }
 
     if( !bgColor.isValid() && canvas()->view())
-        bgColor = canvas()->view()->palette().active().color(QColorGroup::Base);
+        bgColor = QColor(255, 255, 255);
 
     int w = width();
     int h = height();
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs


[prev in list] [next in list] [prev in thread] [next in thread]