[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [plasmashell] [Bug 372963] plasmashell does not handle changes of the primary screen
From:       Jan-Matthias Braun <bugzilla_noreply () kde ! org>
Date:       2016-12-15 13:51:16
Message-ID: bug-372963-17878-vjJzRIzRmE () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=372963

--- Comment #19 from Jan-Matthias Braun <jan_braun@gmx.net> ---
(In reply to Marco Martin from comment #17)
> (In reply to Jan-Matthias Braun from comment #8)
> > Created attachment 102481 [details]
> > Reimplement desktopForScreen without using m_ScreenPool, now providing
> > correct results and fixing the primary output switching problem.
> 
> can you push it?
> the patch makes sense, i can push it if needed

As I was fiddling in unknown code, of which I didn't (and still don't) know
exactly know everywhere how it should behave, I am unsure about the use of my
patch. I do have the impression, that the crash which occurs when the new
primary display was not in use before, e.g., when two external displays are
disconnected and the laptop display is reactivated to become the primary
display, was connected to my try on a fix.

This could be possible, because in this case the used hash shouldn't provide a
reference to the new primary screen.

But I did not test this hypothesis, because the other patch on phabricater
seems to fix the issue better. I think, I saw this crash without my patch too.,
but ... this whole multi-display thingy is quite unstable in my experience,
still, and therefore ugly to test & debug.

You see, I am somewhat guarded against using my patch. The other patch does
good, so lets go with that. Probably that guy knew better. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]