[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [plasmashell] [Bug 372963] plasmashell does not handle changes of the primary screen
From:       David Edmundson <bugzilla_noreply () kde ! org>
Date:       2016-12-15 13:42:31
Message-ID: bug-372963-17878-Ejfp39usM7 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=372963

David Edmundson <kde@davidedmundson.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/pla
                   |                            |sma-workspace/bdfa0f3fb726f
                   |                            |4c639d2ea86d829c25c89779025

--- Comment #18 from David Edmundson <kde@davidedmundson.co.uk> ---
Git commit bdfa0f3fb726f4c639d2ea86d829c25c89779025 by David Edmundson, on
behalf of Jakub Gocoł.
Committed on 15/12/2016 at 13:42.
Pushed by davidedmundson into branch 'Plasma/5.8'.

Move updating of primary screen in screenpool after fetching its id

Summary: We need old id of new primary screen. After we update primary screen
in screenpool, it will always return id = 0. It causes invalid
m_desktopViewforId mapping and  panel doesn't move next time when we change
primary screen.

Test Plan:
Preconditions:
Computer with 1 display, running plasmashell

Test steps:
1. Connect one external screen (first screen is primary)
2. Change primary screen to second screen
3. Change primary screen back to first screen
4.  Unplug second screen

Expected:
In step 3 panel moves to first screen
In step 4 plasmashell keeps running

Actual (before change):
In step 3 panel remains on second display
In step 4 plasmashell crashes

Reviewers: #plasma, davidedmundson

Reviewed By: #plasma, davidedmundson

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D3519

M  +1    -2    shell/shellcorona.cpp

https://commits.kde.org/plasma-workspace/bdfa0f3fb726f4c639d2ea86d829c25c89779025

-- 
You are receiving this mail because:
You are watching all bug changes.=
[prev in list] [next in list] [prev in thread] [next in thread]