[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [kwin] [Bug 350826] [virtual box related?] Show desktop occasionally doesn't toggle on first invocat
From:       via KDE Bugzilla <bugzilla_noreply () kde ! org>
Date:       2015-11-27 9:11:41
Message-ID: bug-350826-17878-uGSdlWtO7A () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=350826

--- Comment #29 from jeremy9856@gmail.com ---
The patch don't seem to be complete and doesn't work. I have this message when
I try to apply it :

patching file abstract_client.cpp
patch unexpectedly ends in middle of line
Hunk #1 FAILED at 216.
1 out of 1 hunk FAILED -- saving rejects to file abstract_client.cpp.rej

So I removed the comments and used this only :

diff --git a/abstract_client.cpp b/abstract_client.cpp
index cbe5eb6..d4a52b0 100644
--- a/abstract_client.cpp
+++ b/abstract_client.cpp
@@ -216,6 +216,10 @@ void AbstractClient::invalidateLayer()

 Layer AbstractClient::belongsToLayer() const
 {
+    if (workspace()->showingDesktop()) {
+        qDebug() << "\'ID:" << window() << ";WMCLASS:" << resourceClass() <<
":"
+           << resourceName() << ";Caption:" << caption() << "\'" << geometry()
<< isDesktop();
+    }

And that seem to work :

patching file abstract_client.cpp
Hunk #1 succeeded at 155 with fuzz 2 (offset -61 lines).

Just to be sure this is the output when I apply the first patch :

patching file client.cpp
Hunk #1 succeeded at 1426 (offset 36 lines).
patching file effects.cpp
Hunk #1 succeeded at 914 (offset -4 lines).
patching file netinfo.cpp
patching file useractions.cpp
Hunk #1 succeeded at 1475 (offset 32 lines).
patching file workspace.cpp
Hunk #1 succeeded at 356 (offset 8 lines).
Hunk #2 succeeded at 915 (offset -1 lines).
Hunk #3 succeeded at 1037 (offset -1 lines).
Hunk #4 succeeded at 1247 (offset -1 lines).

Also note that I use the 5.4 branch.

-- 
You are receiving this mail because:
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]