[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [frameworks-kiconthemes] [Bug 342906] KIconEngine causes QIcon::hasThemeIcon to be always true
From:       Alexander Görtz <kde () nyloc ! de>
Date:       2015-01-31 23:28:38
Message-ID: bug-342906-17878-K9x4w7y7X0 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=342906

Alexander Görtz <kde@nyloc.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kde@nyloc.de

--- Comment #3 from Alexander Görtz <kde@nyloc.de> ---
Hi, indeed this looks a bit strange here is the check for hasThemeIcon:
https://qt.gitorious.org/qt/qtbase/source/73a1e8c60d894701f34806cc4b847aa2814bf389:src/gui/image/qicon.cpp#L1198-1203


and this the used fromTheme function:
https://qt.gitorious.org/qt/qtbase/source/73a1e8c60d894701f34806cc4b847aa2814bf389:src/gui/image/qicon.cpp#L1167-1188


So as the hasThemeIcon function  calls fromTheme with no fallback the Null Icon
should be returned if the theme has no icon for the given name
(availableSizes.isEmpty). So to fix this "KDE" should not report available
sizes for icons that are definitely not in the current theme. I'm not sure this
is fixable on the qt side as they rely on the platform theme implementation. I
guess this whole QPA stuff moves a lot of responsibility to the KDE devs ;).

-- 
You are receiving this mail because:
You are watching all bug changes.=


[prev in list] [next in list] [prev in thread] [next in thread]