From kde-bugs-dist Sat Jan 31 23:28:38 2015 From: =?UTF-8?Q?Alexander=20G=C3=B6rtz=20?= Date: Sat, 31 Jan 2015 23:28:38 +0000 To: kde-bugs-dist Subject: [frameworks-kiconthemes] [Bug 342906] KIconEngine causes QIcon::hasThemeIcon to be always true Message-Id: X-MARC-Message: https://marc.info/?l=kde-bugs-dist&m=142274692820952 https://bugs.kde.org/show_bug.cgi?id=3D342906 Alexander G=C3=B6rtz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kde@nyloc.de --- Comment #3 from Alexander G=C3=B6rtz --- Hi, indeed this looks a bit strange here is the check for hasThemeIcon: https://qt.gitorious.org/qt/qtbase/source/73a1e8c60d894701f34806cc4b847aa28= 14bf389:src/gui/image/qicon.cpp#L1198-1203 and this the used fromTheme function: https://qt.gitorious.org/qt/qtbase/source/73a1e8c60d894701f34806cc4b847aa28= 14bf389:src/gui/image/qicon.cpp#L1167-1188 So as the hasThemeIcon function calls fromTheme with no fallback the Null = Icon should be returned if the theme has no icon for the given name (availableSizes.isEmpty). So to fix this "KDE" should not report available sizes for icons that are definitely not in the current theme. I'm not sure = this is fixable on the qt side as they rely on the platform theme implementation= . I guess this whole QPA stuff moves a lot of responsibility to the KDE devs ;). --=20 You are receiving this mail because: You are watching all bug changes.=