[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 271824] Dolphin runs scripts in a wrong working directory
From:       Tautvydas Andrikys <esminis () esminis ! lt>
Date:       2011-09-30 18:46:59
Message-ID: E1R9i6t-0000h2-30 () bugs ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=271824


Tautvydas Andrikys <esminis@esminis.lt> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #62120|0                           |1
        is obsolete|                            |
  Attachment #64035|0                           |1
        is obsolete|                            |




--- Comment #10 from Tautvydas Andrikys <esminis esminis lt>  2011-09-30 18:46:58 ---
Created an attachment (id=64104)
 --> (http://bugs.kde.org/attachment.cgi?id=64104)
New patch

Change my patch so that kdelibs changes are not required.

> Thanks for the quick reply and the kdelibs patch!
>
> The approach looks good overall (but note that 
> I'm not the maintainer of that code, so this
> still needs to be reviewed by other people).
>
> There is a little problem though: If this
> patch should be included in kdelibs
> 4.x (and not only in the frameworks branch), 
> binary compatibility must be maintained (see [1] for details).
>
> Essentially, this means that you cannot add new parameters 
> to a function, even if they have default values -> you need
> to add a new function, which has one parameter more. In 
> the .cpp files, you can keep your modified functions though,
> and just add a small function with the old signature
> that calls the new function.
>
> If you have any questions about that, don't hesitate to ask :-)
> 
> Could you try to update your kdelibs patch and submit it to
> http://reviewboard.kde.org/ ?
>
> [1] http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]