[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-bugs-dist
Subject:    [Bug 271824] Dolphin runs scripts in a wrong working directory
From:       Frank Reininghaus <frank78ac () googlemail ! com>
Date:       2011-09-29 19:23:06
Message-ID: E1R9MCI-00011y-7D () bugs ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=271824





--- Comment #9 from Frank Reininghaus <frank78ac googlemail com>  2011-09-29 19:23:05 ---
Thanks for the quick reply and the kdelibs patch!

The approach looks good overall (but note that I'm not the maintainer of that
code, so this still needs to be reviewed by other people).

There is a little problem though: If this patch should be included in kdelibs
4.x (and not only in the frameworks branch), binary compatibility must be
maintained (see [1] for details).

Essentially, this means that you cannot add new parameters to a function, even
if they have default values -> you need to add a new function, which has one
parameter more. In the .cpp files, you can keep your modified functions though,
and just add a small function with the old signature that calls the new
function.

If you have any questions about that, don't hesitate to ask :-)

Could you try to update your kdelibs patch and submit it to
http://reviewboard.kde.org/ ?

[1] http://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.
[prev in list] [next in list] [prev in thread] [next in thread]