[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-commits
Subject:    [Wireshark-commits] master 6e609d1: mgcp: don't THROW() an exception from a dissector
From:       Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date:       2016-05-31 10:35:14
Message-ID: 20160531103501.1865.78229 () thud ! wireshark ! org
[Download RAW message or body]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6e609d1a2b16624effece519559984c6564a4a58
Submitter: Anders Broman (a.broman58@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

6e609d1 by Martin Kaiser (wireshark@kaiser.cx):

    mgcp: don't THROW() an exception from a dissector
    
    we can simply abort the dissection for invalid lines or token lengths
    
    Change-Id: I14e02f49a8803db7ec0a5f5c5139705091fd926a
    Reviewed-on: https://code.wireshark.org/review/15628
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    

Actions performed:

    from  ed42a48   mgcp: clean up dissect_mgcp()
    adds  6e609d1   mgcp: don't THROW() an exception from a dissector


Summary of changes:
 epan/dissectors/packet-mgcp.c |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic