[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wireshark-commits
Subject:    [Wireshark-commits] master ed42a48: mgcp: clean up dissect_mgcp()
From:       Wireshark code review <code-review-do-not-reply () wireshark ! org>
Date:       2016-05-31 10:32:23
Message-ID: 20160531103210.1428.89814 () thud ! wireshark ! org
[Download RAW message or body]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ed42a485ef6c64b568969b7697cb1f25d6ecd43d
Submitter: Anders Broman (a.broman58@gmail.com)
Changed: branch: master
Repository: wireshark

Commits:

ed42a48 by Martin Kaiser (wireshark@kaiser.cx):

    mgcp: clean up dissect_mgcp()
    
    remove some if (tree) checks
    rewrite the initial check for a valid packet
    use the correct data type for ti
    
    Change-Id: I56f103be074606e7741db395976e28b4fe27d137
    Reviewed-on: https://code.wireshark.org/review/15629
    Reviewed-by: Anders Broman <a.broman58@gmail.com>
    

Actions performed:

    from  aba533c   mgcp: don't throw an exception while checking if it is our packet
    adds  ed42a48   mgcp: clean up dissect_mgcp()


Summary of changes:
 epan/dissectors/packet-mgcp.c |  119 +++++++++++++++++++----------------------
 1 file changed, 56 insertions(+), 63 deletions(-)
___________________________________________________________________________
Sent via:    Wireshark-commits mailing list <wireshark-commits@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-commits
Unsubscribe: https://wireshark.org/mailman/options/wireshark-commits
             mailto:wireshark-commits-request@wireshark.org?subject=unsubscribe
[prev in list] [next in list] [prev in thread] [next in thread]