[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: Class Cursors
From:       Ulrich Weigand <weigand () informatik ! uni-erlangen ! de>
Date:       1999-07-30 21:20:03
[Download RAW message or body]


> To fix the first, I'm adding a cache, in objects/cursoricon.c, of
> cursors returned from LoadOEMResource() so that when we go to free them
> (near the FIXME in CURSORICON_Destroy) we can tell that it's
> an OEM resource and we shouldn't destroy it.

Just a suggestion: you might have noticed that there is already a 
cache for shared icons;  maybe we should simply store the OEM resources
there as well (say, under hInstance == 0)?

Actually, OEM resource handling is IMHO a little broken anyway; once
the resource compiler understands XPM format, the special hack using
the X11 device driver should be removed, and the OEM resources should
simply be loaded from the normal resources of the built-in USER32.DLL ...
Then, loading, creating, and destroying of OEM resources should be
done just the same as for all other resources.

Bye,
Ulrich

-- 
  Ulrich Weigand,
  IMMD 1, Universitaet Erlangen-Nuernberg,
  Martensstr. 3, D-91058 Erlangen, Phone: +49 9131 85-7688


=========================================================================

[prev in list] [next in list] [prev in thread] [next in thread]