[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH vkd3d v2 2/6] vkd3d-shader: Return a vkd3d_string_buffer from hlsl_modifiers_to_string().
From:       "Zebediah Figura (she/her)" <zfigura () codeweavers ! com>
Date:       2021-02-28 0:03:39
Message-ID: 2359c6df-1d96-3add-e39e-74eb56f256be () codeweavers ! com
[Download RAW message or body]

[Attachment #2 (multipart/mixed)]


On 2/27/21 3:55 AM, Matteo Bruni wrote:
> On Fri, Feb 26, 2021 at 7:45 PM Zebediah Figura <zfigura@codeweavers.com> wrote:
>>
>> Signed-off-by: Zebediah Figura <zfigura@codeweavers.com>
>> ---
>>  libs/vkd3d-shader/hlsl.c | 54 +++++++++++++++++++++-------------------
>>  libs/vkd3d-shader/hlsl.h |  3 ++-
>>  libs/vkd3d-shader/hlsl.y | 16 ++++++------
>>  3 files changed, 38 insertions(+), 35 deletions(-)
>>
>> diff --git a/libs/vkd3d-shader/hlsl.c b/libs/vkd3d-shader/hlsl.c
>> index e2a77707..dbc03a80 100644
>> --- a/libs/vkd3d-shader/hlsl.c
>> +++ b/libs/vkd3d-shader/hlsl.c
>> @@ -730,46 +730,45 @@ const char *debug_hlsl_type(const struct hlsl_type *type)
>>      return ret;
>>  }
>>
>> -char *hlsl_modifiers_to_string(unsigned int modifiers)
>> +struct vkd3d_string_buffer *hlsl_modifiers_to_string(struct vkd3d_string_buffer_list *string_buffers,
>> +        unsigned int modifiers)
> 
> It looks like this is the old version of the patch, not rebased on top
> of patch 1/6 v2.
> 

Sorry about that; resent.


["OpenPGP_signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]