[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] user32: Allow mouse messages to land on windows below top-level HTTRANSPARENT windows.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2018-01-31 16:48:55
Message-ID: 87a7wu55zc.fsf () winehq ! org
[Download RAW message or body]

Huw Davies <huw@codeweavers.com> writes:

> @@ -2502,7 +2502,7 @@ static BOOL process_mouse_message( MSG *msg, UINT hw_id, ULONG_PTR extra_info, H
>      }
>      else
>      {
> -        msg->hwnd = WINPOS_WindowFromPoint( msg->hwnd, msg->pt, &hittest );
> +        msg->hwnd = WINPOS_WindowFromPoint( 0, msg->pt, &hittest );

In general we want to trust the X11 window information over the
wineserver. In particular I don't think we want to send a mouse click to
some unrelated window that may be behind another X11 window. Also note
that the same patch in staging has been reported to cause regressions.

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]