[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH resend 2/2] winex11.drv, winemac.drv: Don't send WM_CANCELMODE on focus loss.
From:       Zebediah Figura <z.figura12 () gmail ! com>
Date:       2018-01-31 16:22:47
Message-ID: 7b04389e-2444-d53c-a711-a09e71d361ec () gmail ! com
[Download RAW message or body]

On 30/01/18 20:56, Dmitry Timoshkov wrote:
> Zebediah Figura <z.figura12@gmail.com> wrote:
> 
>> --- a/dlls/winex11.drv/event.c
>> +++ b/dlls/winex11.drv/event.c
>> @@ -804,7 +804,6 @@ static BOOL X11DRV_FocusIn( HWND hwnd, XEvent *xev )
>>          return;
>>      }
>>      if (hwnd != GetForegroundWindow()) return;
>> -    SendMessageW( hwnd, WM_CANCELMODE, 0, 0 );
>>  
>>      /* don't reset the foreground window, if the window which is
>>         getting the focus is a Wine window */
> 
> Menu modal loop depends on this, and probably will be broken if
> WM_CANCELMODE no longer sent.
> 

Actually, as far as my testing shows, it's broken right now. Windows
doesn't send WM_CANCELMODE on focus loss, even if the window is tracking
a menu.



[prev in list] [next in list] [prev in thread] [next in thread]