[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [v1 1/5] winejoystick.drv: Add functionality to disable joystick via registry
From:       DavidL <david.dljunk () gmail ! com>
Date:       2016-08-29 11:04:48
Message-ID: CAD6OkWmOdOpDn+GmEewNi51898dpXA_Bav-kd+JBoxbZ+Txd-w () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Fixed and resent, thanks!

David

On Sat, Aug 27, 2016 at 11:28 PM, Bruno Jesus <00cpxxx@gmail.com> wrote:

> On Sun, Aug 28, 2016 at 3:18 AM, David Lawrie <david.dljunk@gmail.com>
> wrote:
> > Adds device_disabled_registry, helper functions to shared joystick code
>
> Hi, thanks for working on this. The problem with this series is that
> you are introducing dead code in patches 1, 2 and 3. As the code is
> not used anywhere until patch 5.
> Patch 4 also adds dead code that is only used in patch 5.
>
> IMO you should merge patches 1,2,3 into a single patch and also 4 and
> 5 into second patch. This will make the dead code will last a single
> commit.
>
> Best wishes,
> Bruno
>

[Attachment #5 (text/html)]

<div dir="ltr">Fixed and resent, thanks!<div><br></div><div>David</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Sat, Aug 27, 2016 at 11:28 PM, \
Bruno Jesus <span dir="ltr">&lt;<a href="mailto:00cpxxx@gmail.com" \
target="_blank">00cpxxx@gmail.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><span class="">On Sun, Aug 28, 2016 at 3:18 AM, David Lawrie \
&lt;<a href="mailto:david.dljunk@gmail.com">david.dljunk@gmail.com</a>&gt; wrote:<br> \
&gt; Adds device_disabled_registry, helper functions to shared joystick code<br> <br>
</span>Hi, thanks for working on this. The problem with this series is that<br>
you are introducing dead code in patches 1, 2 and 3. As the code is<br>
not used anywhere until patch 5.<br>
Patch 4 also adds dead code that is only used in patch 5.<br>
<br>
IMO you should merge patches 1,2,3 into a single patch and also 4 and<br>
5 into second patch. This will make the dead code will last a single<br>
commit.<br>
<br>
Best wishes,<br>
Bruno<br>
</blockquote></div><br></div>


[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]