[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 3/3] ntdll: For Mac 64-bit, poke NtCurrentTeb()->ThreadLocalStoragePointer to the corresp
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2016-07-28 2:29:38
Message-ID: 874m7amr59.fsf () winehq ! org
[Download RAW message or body]

Sebastian Lackner <sebastian@fds-team.de> writes:

> It looks like RtlRunOnceExecuteOnce is not safe to use (keyed_event not initialized yet).
> You could use pthread (like used before in init_teb_key), but probably moving to
> a function is sufficient to improve code readability. By avoiding the heavily indented
> code it would already look a bit less hacky. ;)

Simplifying the error handling would probably also help. For instance,
pthread_setspecific() is not going to fail in any meaningful way.

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]