[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/6] d3drm: Implement IDirect3DRMViewport*::Init. (v7)
From:       Aaryaman Vasishta <jem456.vasishta () gmail ! com>
Date:       2016-07-27 19:42:27
Message-ID: CABVHfRtqztxA3yt1p89WoNGiTkJjM9m2Q2R8YJDbm8cAZn=k4Q () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Jul 28, 2016 at 12:53 AM, Henri Verbeet <hverbeet@gmail.com> wrote:

> On 27 July 2016 at 21:09, Aaryaman Vasishta <jem456.vasishta@gmail.com>
> wrote:
> > On Thu, Jul 28, 2016 at 12:13 AM, Stefan D=C3=B6singer
> >> > +    if (material)
> >> > +        IDirect3DMaterial_Release(material);
> >> This will destroy the material, viewport::SetBackground doesn't addref
> it.
> >
> > Right, henri suggested the same. I'll move this outside the cleanup
> label.
> I did say the sequence was odd, but it does work because "material" is
> set to NULL on successful viewport initialisation. On the other hand,
> I just noticed you'll also leak the material if
> IDirect3DViewport_SetBackground() fails.
>
Right, sorry to not mention about the sequence. I also noticed the leak
while fixing the same.

Cheers,
Aaryaman

[Attachment #5 (text/html)]

<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Jul \
28, 2016 at 12:53 AM, Henri Verbeet <span dir="ltr">&lt;<a \
href="mailto:hverbeet@gmail.com" target="_blank">hverbeet@gmail.com</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex"><span class="">On 27 July 2016 at 21:09, Aaryaman \
Vasishta &lt;<a href="mailto:jem456.vasishta@gmail.com">jem456.vasishta@gmail.com</a>&gt; \
wrote:<br> &gt; On Thu, Jul 28, 2016 at 12:13 AM, Stefan Dösinger<br>
</span><span class="">&gt;&gt; &gt; +      if (material)<br>
&gt;&gt; &gt; +            IDirect3DMaterial_Release(material);<br>
&gt;&gt; This will destroy the material, viewport::SetBackground doesn&#39;t addref \
it.<br> &gt;<br>
&gt; Right, henri suggested the same. I&#39;ll move this outside the cleanup \
label.<br> </span>I did say the sequence was odd, but it does work because \
&quot;material&quot; is<br> set to NULL on successful viewport initialisation. On the \
other hand,<br> I just noticed you&#39;ll also leak the material if<br>
IDirect3DViewport_SetBackground() fails.<br></blockquote><div>Right, sorry to not \
mention about the sequence. I also noticed the leak while fixing the \
same.<br><br></div><div>Cheers,<br></div><div>Aaryaman<br></div></div><br></div></div>



[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]